From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3wi-0004oZ-J7 for qemu-devel@nongnu.org; Thu, 08 Sep 2016 14:21:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bi3wd-0000yo-Jz for qemu-devel@nongnu.org; Thu, 08 Sep 2016 14:21:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bi3wd-0000yk-Bk for qemu-devel@nongnu.org; Thu, 08 Sep 2016 14:21:03 -0400 References: <1473076452-19795-1-git-send-email-rabin.vincent@axis.com> From: Eric Blake Message-ID: Date: Thu, 8 Sep 2016 13:21:01 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mP05XVoWlIAbU30wTfRaWvlVwLS09MahP" Subject: Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Rabin Vincent Cc: "Edgar E. Iglesias" , QEMU Developers , Rabin Vincent This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mP05XVoWlIAbU30wTfRaWvlVwLS09MahP From: Eric Blake To: Peter Maydell , Rabin Vincent Cc: "Edgar E. Iglesias" , QEMU Developers , Rabin Vincent Message-ID: Subject: Re: [Qemu-devel] [PATCH 1/9] tests: cris: force inlining References: <1473076452-19795-1-git-send-email-rabin.vincent@axis.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/08/2016 01:06 PM, Peter Maydell wrote: >> +++ b/tests/tcg/cris/sys.h >> @@ -3,6 +3,8 @@ >> #define STRINGIFY(x) #x >> #define TOSTRING(x) STRINGIFY(x) >> >> +#define inline inline __attribute__((always_inline)) >> + >=20 > I think redefining C keywords is generally a bad idea. > Can you instead define an "always_inline" macro and > use it where necessary? In fact, commit b11d029b is an instance where compilation failed weirdly because we redefined inline. I agree that a separate macro name, added on where desired, rather than redefining 'inline' itself, is desirable. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mP05XVoWlIAbU30wTfRaWvlVwLS09MahP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX0awNAAoJEKeha0olJ0NqekAH/jMRahpi+gs4vMLPYQM38sbP BK9rRiNPyvbp13V3fWFSBrTv/kwRR7+qm1vhg0Wbv8TJI09Ymrno/DkRmflfZzLj 6/GlpGpEs/dxqgifywUb0Xf5s/c2JoM8gJwjOy6J2ZLIRvdOJxtT85uJErw/atjP eeRLEBKkEDuf7CgEYahQivjiaK7Q4pSy2k8vu8AQtIXr4jB07LLZk/v/waf9f374 kgvgXmRa5O0r2ch2sS482meJOt+Ae+6Z0lweclRloJSpMJxyaB3mNnnBz/rNbl4q T3K8qf8tbCvAXydA5Ewi4+arsTczLMOEn/7/sWBwoLewNJgd5pk71x75wmbn5CU= =vBUY -----END PGP SIGNATURE----- --mP05XVoWlIAbU30wTfRaWvlVwLS09MahP--