Re: [PATCH v3 1/3] win32: remove usage of attribute gcc_struct

[Richard Henderson <richard.henderson@linaro.org>]

On 11/28/24 14:15, Pierrick Bouvier wrote:
> This attribute is not recognized by clang.
> 
> An investigation has been performed to ensure this attribute has no
> effect on layout of structures we use in QEMU [1], so it's safe to
> remove now.
> 
> In the future, we'll forbid introducing new bitfields in packed struct,
> as they are the one potentially impacted by this change.
> 
> [1] https://lore.kernel.org/qemu-devel/66c346de-7e20-4831-b3eb-1cda83240af9@linaro.org/
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   meson.build                               | 5 -----
>   include/qemu/compiler.h                   | 7 +------
>   scripts/cocci-macro-file.h                | 6 +-----
>   subprojects/libvhost-user/libvhost-user.h | 6 +-----
>   4 files changed, 3 insertions(+), 21 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~