From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Subject: Re: [PATCH-for-9.0] accel/tcg: Remove unused tb_invalidate_phys_addr()
Date: Thu, 30 Nov 2023 16:31:55 -0600 [thread overview]
Message-ID: <a44716ad-aa83-403e-bdf1-a75f6c76f420@linaro.org> (raw)
In-Reply-To: <20231130203241.31099-1-philmd@linaro.org>
On 11/30/23 14:32, Philippe Mathieu-Daudé wrote:
> Commit e3f7c801f1 introduced the TCGCPUOps::debug_check_breakpoint()
> handler, and commit 10c37828b2 "moved breakpoint recognition outside
> of translation", so "we no longer need to flush any TBs when changing
> BPs".
>
> The last target using tb_invalidate_phys_addr() was converted to the
> debug_check_breakpoint(), so this function is now unused. Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Based-on: <20231130171920.3798954-1-jcmvbkbc@gmail.com>
> ---
> include/exec/exec-all.h | 5 -----
> cpu-target.c | 29 -----------------------------
> 2 files changed, 34 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2023-11-30 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 20:32 [PATCH-for-9.0] accel/tcg: Remove unused tb_invalidate_phys_addr() Philippe Mathieu-Daudé
2023-11-30 22:31 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44716ad-aa83-403e-bdf1-a75f6c76f420@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).