From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-devel@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
"Guido Günther" <agx@sigxcpu.org>
Subject: Re: [Qemu-devel] [PATCH v3 11/13] linux-user/strace: Add print_sockaddr_ptr() to handle plain/pointer addrlen
Date: Mon, 2 Jul 2018 20:52:11 +0200 [thread overview]
Message-ID: <a44c7017-4da8-c812-b7da-0d3c0751a9d0@vivier.eu> (raw)
In-Reply-To: <20180702175030.18621-12-f4bug@amsat.org>
Le 02/07/2018 à 19:50, Philippe Mathieu-Daudé a écrit :
> While very similar to send()/recv(), the format used by
> sendto()/recvfrom() is slightly different: the 'addrlen'
> is not a plain sockaddr_t but a pointer to it.
>
> Split the current function to handle both formats.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-By: Guido Günther <agx@sigxcpu.org>
> ---
> linux-user/strace.c | 28 ++++++++++++++++++++++++++--
> 1 file changed, 26 insertions(+), 2 deletions(-)
>
In the following patches I think you can use do_print_sockaddr() and
don't have to define print_sockaddr_ptr()
Thanks,
Laurent
next prev parent reply other threads:[~2018-07-02 18:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 17:50 [Qemu-devel] [PATCH v3 00/13] linux-user: strace improvements Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 01/13] linux-user/syscall: Verify recvfrom(addr) is user-writable Philippe Mathieu-Daudé
2018-07-03 14:55 ` Laurent Vivier
2018-07-03 15:39 ` Philippe Mathieu-Daudé
2018-07-03 16:38 ` Laurent Vivier
2018-07-03 21:05 ` Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 02/13] linux-user/strace: Improve capget()/capset() output Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 05/13] linux-user/strace: Improve settimeofday() Philippe Mathieu-Daudé
2018-07-02 18:20 ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 06/13] linux-user/strace: Dump AF_NETLINK sockaddr content Philippe Mathieu-Daudé
2018-07-02 19:05 ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 07/13] linux-user/strace: Improve recvmsg() output Philippe Mathieu-Daudé
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 10/13] linux-user/strace: Let print_sockaddr() have a 'last' argument Philippe Mathieu-Daudé
2018-07-02 18:40 ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 11/13] linux-user/strace: Add print_sockaddr_ptr() to handle plain/pointer addrlen Philippe Mathieu-Daudé
2018-07-02 18:52 ` Laurent Vivier [this message]
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 12/13] linux-user/strace: Improve getsockname() output Philippe Mathieu-Daudé
2018-07-02 18:46 ` Laurent Vivier
2018-07-02 17:50 ` [Qemu-devel] [PATCH v3 13/13] linux-user/strace: Improve recvfrom() output Philippe Mathieu-Daudé
2018-07-02 18:44 ` Laurent Vivier
[not found] ` <20180702175030.18621-4-f4bug@amsat.org>
2018-07-02 18:18 ` [Qemu-devel] [PATCH v3 03/13] linux-user/strace: Display invalid pointer in print_timeval() Laurent Vivier
2018-07-02 18:26 ` Philippe Mathieu-Daudé
[not found] ` <20180702175030.18621-5-f4bug@amsat.org>
2018-07-02 18:19 ` [Qemu-devel] [PATCH v3 04/13] linux-user/strace: Add print_timezone() Laurent Vivier
[not found] ` <20180702175030.18621-9-f4bug@amsat.org>
2018-07-02 18:30 ` [Qemu-devel] [PATCH v3 08/13] linux-user/strace: Improve bind() output Laurent Vivier
[not found] ` <20180702175030.18621-10-f4bug@amsat.org>
2018-07-02 18:36 ` [Qemu-devel] [PATCH v3 09/13] linux-user/strace: improve sendto() output Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44c7017-4da8-c812-b7da-0d3c0751a9d0@vivier.eu \
--to=laurent@vivier.eu \
--cc=agx@sigxcpu.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).