From: Amit Shah <amit.shah@redhat.com>
To: qemu list <qemu-devel@nongnu.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug
Date: Thu, 28 Jul 2011 11:47:16 +0530 [thread overview]
Message-ID: <a46188e6a60af14320305af614c43fc9581a5b07.1311833521.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1311833521.git.amit.shah@redhat.com>
In-Reply-To: <cover.1311833521.git.amit.shah@redhat.com>
Migrating after unplugging a virtio-balloon device resulted in an error
message on the destination:
Unknown savevm section or instance '0000:00:04.0/virtio-balloon' 0
load of migration failed
Fix this by unregistering the section on device unplug.
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-balloon.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 0ce0049..072a88a 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -45,6 +45,7 @@ typedef struct VirtIOBalloon
size_t stats_vq_offset;
MonitorCompletion *stats_callback;
void *stats_opaque_callback_data;
+ DeviceState *qdev;
} VirtIOBalloon;
static VirtIOBalloon *to_virtio_balloon(VirtIODevice *vdev)
@@ -292,6 +293,7 @@ VirtIODevice *virtio_balloon_init(DeviceState *dev)
reset_stats(s);
+ s->qdev = dev;
register_savevm(dev, "virtio-balloon", -1, 1,
virtio_balloon_save, virtio_balloon_load, s);
@@ -300,5 +302,7 @@ VirtIODevice *virtio_balloon_init(DeviceState *dev)
void virtio_balloon_exit(VirtIODevice *vdev)
{
+ VirtIOBalloon *s = DO_UPCAST(VirtIOBalloon, vdev, vdev);
+ unregister_savevm(s->qdev, "virtio-balloon", s);
virtio_cleanup(vdev);
}
--
1.7.6
next prev parent reply other threads:[~2011-07-28 6:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 6:17 [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug Amit Shah
2011-07-28 6:17 ` [Qemu-devel] [PATCH v2 1/5] balloon: Don't allow multiple balloon handler registrations Amit Shah
2011-07-28 6:17 ` [Qemu-devel] [PATCH v2 2/5] virtio-balloon: Check if balloon registration failed Amit Shah
2011-07-28 6:17 ` [Qemu-devel] [PATCH v2 3/5] balloon: Ignore negative balloon values Amit Shah
2011-07-28 7:31 ` Markus Armbruster
2011-07-28 9:36 ` Amit Shah
2011-07-28 6:17 ` [Qemu-devel] [PATCH v2 4/5] virtio-balloon: Add exit handler, fix memleaks Amit Shah
2011-07-28 6:28 ` Amit Shah
2011-07-28 7:39 ` Markus Armbruster
2011-07-28 9:37 ` Amit Shah
2011-07-28 7:35 ` Markus Armbruster
2011-07-28 6:17 ` Amit Shah [this message]
2011-07-28 7:45 ` [Qemu-devel] [PATCH v2 5/5] virtio-balloon: Unregister savevm section on device unplug Markus Armbruster
2011-07-28 9:37 ` Amit Shah
2011-07-28 11:06 ` Michael S. Tsirkin
2011-07-28 12:21 ` Markus Armbruster
2011-07-28 12:27 ` Michael S. Tsirkin
2011-07-28 7:46 ` [Qemu-devel] [PATCH v2 0/5] balloon: fix memleaks, invalid arguments, unplug Markus Armbruster
2011-07-28 8:49 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a46188e6a60af14320305af614c43fc9581a5b07.1311833521.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).