From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCD2C433DB for ; Mon, 15 Feb 2021 10:58:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03B9964D9D for ; Mon, 15 Feb 2021 10:58:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03B9964D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBbaH-0001Uv-Q0 for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 05:58:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBbYj-0000aL-AO; Mon, 15 Feb 2021 05:56:56 -0500 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:33994) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lBbYf-0003ck-RX; Mon, 15 Feb 2021 05:56:52 -0500 Received: by mail-wr1-x434.google.com with SMTP id n4so5347588wrx.1; Mon, 15 Feb 2021 02:56:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/ddFKPEtA+bqBplywm4Eu0wtttSsmgjNCeWOYYFfoc0=; b=W4E1gI6/AnGQflTxYw+v+5WDi4u+6NJAZpyKggJzw7N4KuJq4O3u5z8MTYiClp6rB3 l+pDixuZCfv0I13j5C44TsSAyYidPXSRNY7ymMD9aa3sw0pB25WPmmKhAoxEjd0DW38B rpu9PF6mwt8T/ohGlFrWxgi9yulVWBBMEaAa2md2OL4TrnzkuGlaVjUWVTxMFsgXULDU TL+oxzjVSnHE4OzCJOW5oqyM8isZg9YqaXecXR7yBT+DHCfDv05WsYWyRqFJZAMJQrsb g0jagjIGEB2p8XVj3uE26yDC9grMOiMDykZzuNyvPq/1OE7d7d0rPKhRY13wf5qPtoOx YDLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/ddFKPEtA+bqBplywm4Eu0wtttSsmgjNCeWOYYFfoc0=; b=hfGmTPA2/P3vtfoFcTJZVq8TwyhBSjcLGmTP5LswZWhYdcssMFe4PvKylqSxiP15PY +p2y7GClOxptpFaGcPkf5TQ/C+WEIa8370SXI3GY3Fv+v842q5l/hQmP8+89ys+oSwhn g2Xc/+c4LfDQqK5baf40izhfTVr5wgkV9CH9CwBVw6jEIJCcLwARQMVIEEc4xXivHf9m +BCR9NU+goCcDP3AuXgb1l5bGnYYel+GbXAI7V5Di9Pyf7lRVB1j6FBtCIOljMDovU4f 2oPMxTH/apPKXszFpjAnbahM2mfwQ4D4aQnlmVbqLVRyr0eyDYeJchtZnPFQ/A/ans9V BXyA== X-Gm-Message-State: AOAM533c4JqI5e9nUviWrgWQyMEcNAxBnb5LAlriMkualykLGCb+X+Ad CKhaNdwjQRp6NG04GnfmaOo= X-Google-Smtp-Source: ABdhPJy3yf1f6LYlKHfhx1zcwS7f9UXzbuPeSRYkO93puL44hDt7xYuXrDZUrHxGDrTGng1PI4t0qA== X-Received: by 2002:a05:6000:10c5:: with SMTP id b5mr18526029wrx.284.1613386607926; Mon, 15 Feb 2021 02:56:47 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id g15sm23330215wrx.1.2021.02.15.02.56.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Feb 2021 02:56:47 -0800 (PST) Subject: Re: [PATCH 4/9] hw/display/tc6393xb: Inline tc6393xb_draw_graphic32() at its callsite To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210215103215.4944-1-peter.maydell@linaro.org> <20210215103215.4944-5-peter.maydell@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Mon, 15 Feb 2021 11:56:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210215103215.4944-5-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/15/21 11:32 AM, Peter Maydell wrote: > The function tc6393xb_draw_graphic32() is called in exactly one place, > so just inline the function body at its callsite. This allows us to > drop the template header entirely. > > The code move includes a single added space after 'for' to fix > the coding style. > > Signed-off-by: Peter Maydell > --- > hw/display/tc6393xb_template.h | 45 ---------------------------------- > hw/display/tc6393xb.c | 23 ++++++++++++++--- > 2 files changed, 19 insertions(+), 49 deletions(-) > delete mode 100644 hw/display/tc6393xb_template.h Reviewed-by: Philippe Mathieu-Daudé