From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7ECAC433E0 for ; Wed, 10 Mar 2021 12:39:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FE7464FE3 for ; Wed, 10 Mar 2021 12:39:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FE7464FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJy7V-0003aM-Cc for qemu-devel@archiver.kernel.org; Wed, 10 Mar 2021 07:39:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJy6G-00038M-6u for qemu-devel@nongnu.org; Wed, 10 Mar 2021 07:38:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45307) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJy6E-0002dq-BV for qemu-devel@nongnu.org; Wed, 10 Mar 2021 07:38:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615379881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z3iN8BX10Y1p1b59wHjKQeEYKPrF78zDC5ceZQ6LXUs=; b=iTnTzsyPuQELP3WFTXrUTatu5xNSfZNIOrLA4cIGRCorW/UHa6FMBLzWuw8v2EOO3UnvwF 2TwG2LSuoU+Igwfq4sjtARHPfEN0GQD0zz0wMfoeQ/ujNQYYMRb9xd4Jw1uq8LdHnvfSA7 Vm7udUIZsCymSx6Mn8t+x3G/po5FPIQ= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-pJsZVblwPmuJ1gfo8yCrwg-1; Wed, 10 Mar 2021 07:37:59 -0500 X-MC-Unique: pJsZVblwPmuJ1gfo8yCrwg-1 Received: by mail-ed1-f69.google.com with SMTP id q2so8244759edt.16 for ; Wed, 10 Mar 2021 04:37:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z3iN8BX10Y1p1b59wHjKQeEYKPrF78zDC5ceZQ6LXUs=; b=VPxH0R9ovWJ3X8f67e6KWn9PSiV50395482O80jw9bTnt1H/J4PbEh/RvMzukO3IQ+ OYUgQ5Dy+NTU2x+66mcrXIwXc47HBtSwnLMMTqkpyKctGmbjcIZzyTWZwovbSSiwGmGq bkH+kToJWwZLi6q1/eXo69g18VPDnwPVJQOMe35HCzl6rsrHo3CgAMB1VI5Bri7ItnIF oT9vFJRqePyA+nFoWPpBr7kVF13CI6WO/ST12vRr5wHEbYpdC0K9eudTK8obw1p7Gsf6 vuAOdxVtbi3rizoT3bZDTSNOICLQmd232Vs9O5Y2QxfXuHRvw82gvnVgDNli69WJGyuO lJLw== X-Gm-Message-State: AOAM533gtx5y6MyL74rfplNxIlvI3KY0UgYENup3/MOd7Nw82c85Ai02 ih8WszRigTOH4fuyJP2J01rbc+Zig2ivcslsEPy+ELZo+rsyNTAOffpFeUpixrJWIPwfqh6ou5t OIaN7U5amlJUqW2s= X-Received: by 2002:a17:906:4955:: with SMTP id f21mr3570379ejt.74.1615379878312; Wed, 10 Mar 2021 04:37:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyiDKYvgifDWXtilndOnP6DpTohlQBRfLTCfoIWm+TF65z+bKnD3vABE1CEXxK9kWY8MbewHw== X-Received: by 2002:a17:906:4955:: with SMTP id f21mr3570366ejt.74.1615379878195; Wed, 10 Mar 2021 04:37:58 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r17sm9716784ejz.109.2021.03.10.04.37.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 04:37:57 -0800 (PST) Subject: Re: [PATCH 0/3] block: Introduce the 'zeroes-co' driver to help security reports To: Fam Zheng References: <20210310114314.1068957-1-philmd@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 10 Mar 2021 13:37:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.243, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , Bandan Das , Prasad J Pandit Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/10/21 1:32 PM, Fam Zheng wrote: > On Wed, 10 Mar 2021 at 11:44, Philippe Mathieu-Daudé > wrote: > > Hi, > > This is an alternative approach to changing null-co driver > default 'read-zeroes' option to true: > https://www.mail-archive.com/qemu-block@nongnu.org/msg80873.html > > > Instead we introduce yet another block driver with an explicit > name: 'zeroes-co'. We then clarify in secure-coding-practices.rst > that security reports have to be sent using this new driver. > > The 2nd patch is RFC because I won't spend time converting the > tests until the first patch is discussed, as I already spent enough > time doing that in the previous mentioned series. > > Regards, > > Phil. > > Philippe Mathieu-Daudé (3): >   block: Introduce the 'zeroes-co' driver >   tests/test-blockjob: Use zeroes-co instead of null-co,read-zeroes=on >   docs/secure-coding-practices: Describe null-co/zeroes-co block drivers > >  docs/devel/secure-coding-practices.rst |   7 + >  block/zeroes.c                         | 306 +++++++++++++++++++++++++ > > Why not add another BlockDriver struct to block/null.c and set the > read_zeroes field in the .bdrv_file_open callback? It would make the > patch much simpler. This is the first patch I wrote but then realized you are listed as null-co maintainer, so you might be uninterested in having this new driver in the same file. And declaring the prototypes public to reuse them seemed overkill. Anyway I'll try to find a simpler outcome by simply improving documentation.