From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C21E9C7EE29 for ; Fri, 2 Jun 2023 10:28:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q520O-00023D-B3; Fri, 02 Jun 2023 06:27:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q520G-00022p-P0 for qemu-devel@nongnu.org; Fri, 02 Jun 2023 06:27:32 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q520F-0002ZX-2a for qemu-devel@nongnu.org; Fri, 02 Jun 2023 06:27:28 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-30c2bd52f82so1924439f8f.3 for ; Fri, 02 Jun 2023 03:27:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685701645; x=1688293645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HJ/pVCCuC9iawE4p6hPvBzjdsnRt0g4k19hTi247k6U=; b=J01XcSOjYn0aKrCzt5c4QuJryYh3GuBBQ6E4h2X229xsNrANXJCVK1t8HjQtm4EslB FXNxkjUZui9H6oeezeIrK9jZTSlr15PnSDKUwl4mW09krUT3YXmc101RGkNKT12BZ86S a/Je+mIVldXIsNMxlizZRcBOlg9GQHl3Eu8PcyLYeqzdwEPP/FUlXMwkg9SQbR0Tam+5 oaHRMgKsbVljHynd2qB/8hpdiaUPDmdjR0PXZ74ZVXg6n2JZVuw1uMT0JId1ujnepsSM mhUNOoYXddhSrT6VEfZgiM6CRt+SxZrhBWDR0LrwUi5xVgsBuuPD057FhWbXOsACkhGj NxSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685701645; x=1688293645; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HJ/pVCCuC9iawE4p6hPvBzjdsnRt0g4k19hTi247k6U=; b=MduUp6+THKhsd9FqXbiDDU/yJJJogAVPtZnzBIAcgDNKyWIznuFBnWtrgalCxfkWOa uKPOPCNEfPva7yfg4RL+xxQYJc52BzyNdpPFmL0j/Yg7AZUmbI/duXAU05mKusdXZHyl Goec4E2ZP4SXYk9WZ7NKXGZByBek160xOluTty6JKb/dznzM4fob5vFaCWnfiDaerUQW JDY86UTOfGh7jhWS2/QSyvxpV27pQwEBUTVwwno2dNjLoe6U2sHy96vq4gCVMBfpqba3 e4RL2e7wpyFB/4qnszRcEi2HiMWBFZLpjh0EYrfE7AiFXKMIWmgnIbUsBW5kqO5Pauyg GaxA== X-Gm-Message-State: AC+VfDyIOQs8VESuorqCrlayLOvb8OFDNLLtOSV4ByYnLnX7WUEKAaSn 7GTeYdCMiDvQLCgePn0W60KC0w== X-Google-Smtp-Source: ACHHUZ4IzQPd6dlLrVECh3XaDH9qgkFegcv2HOMMiPLoJK7+Lt9Vda3aDLuBnaRh3tr8faxTC7pjxQ== X-Received: by 2002:a5d:52d2:0:b0:306:772:5c2e with SMTP id r18-20020a5d52d2000000b0030607725c2emr3441502wrv.70.1685701645391; Fri, 02 Jun 2023 03:27:25 -0700 (PDT) Received: from [192.168.69.115] ([176.187.218.254]) by smtp.gmail.com with ESMTPSA id b3-20020a5d4d83000000b0030c4d8930b1sm1255318wru.91.2023.06.02.03.27.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 03:27:24 -0700 (PDT) Message-ID: Date: Fri, 2 Jun 2023 12:27:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 1/2] target/arm: allow DC CVA[D]P in user mode emulation Content-Language: en-US To: Zhuojia Shen , qemu-devel@nongnu.org Cc: Peter Maydell , Richard Henderson , qemu-arm@nongnu.org References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/6/23 00:11, Zhuojia Shen wrote: > DC CVAP and DC CVADP instructions can be executed in EL0 on Linux, > either directly when SCTLR_EL1.UCI == 1 or emulated by the kernel (see > user_cache_maint_handler() in arch/arm64/kernel/traps.c). > > This patch enables execution of the two instructions in user mode > emulation. > > Signed-off-by: Zhuojia Shen > Reviewed-by: Peter Maydell > --- > target/arm/helper.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > -#ifndef CONFIG_USER_ONLY > static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque, > uint64_t value) > { > @@ -7420,6 +7419,7 @@ static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque, > /* This won't be crossing page boundaries */ > haddr = probe_read(env, vaddr, dline_size, mem_idx, GETPC()); > if (haddr) { > +#ifndef CONFIG_USER_ONLY This ifdef'ry placement is odd. Is it to silent a unused-but-set-variable warning? > ram_addr_t offset; > MemoryRegion *mr; > @@ -7430,6 +7430,7 @@ static void dccvap_writefn(CPUARMState *env, const ARMCPRegInfo *opaque, > if (mr) { > memory_region_writeback(mr, offset, dline_size); > } > +#endif /*CONFIG_USER_ONLY*/ > } > } > > @@ -7448,7 +7449,6 @@ static const ARMCPRegInfo dcpodp_reg[] = { > .fgt = FGT_DCCVADP, > .accessfn = aa64_cacheop_poc_access, .writefn = dccvap_writefn }, > }; > -#endif /*CONFIG_USER_ONLY*/