qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Sandra Loosemore <sandra@codesourcery.com>, qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, Chris Wulff <crwulff@gmail.com>,
	Marek Vasut <marex@denx.de>
Subject: Re: [Qemu-devel] [PATCH] Fix breakpoint support in Nios II user-mode emulation.
Date: Wed, 13 Feb 2019 21:46:29 +0100	[thread overview]
Message-ID: <a48ece75-537d-72e9-8851-bc7a801f77af@vivier.eu> (raw)
In-Reply-To: <1550076626-7202-1-git-send-email-sandra@codesourcery.com>

CC'ing NiosII Maintainers

On 13/02/2019 17:50, Sandra Loosemore wrote:
> Nios II user-mode emulation was missing handling for EXCP_DEBUG,
> making the gdb stub essentially useless.  This patch adds the missing
> piece.  The new code was copied from the existing EXCP_TRAP handling
> and is also similar to what other targets (e.g., arm) do with EXCP_DEBUG.
> 
> Signed-off-by: Sandra Loosemore <sandra@codesourcery.com>
> ---
>  linux-user/nios2/cpu_loop.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
> index b96b1aa..5aa1eca 100644
> --- a/linux-user/nios2/cpu_loop.c
> +++ b/linux-user/nios2/cpu_loop.c
> @@ -73,6 +73,12 @@ void cpu_loop(CPUNios2State *env)
>                  queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
>                  break;
>              }
> +        case EXCP_DEBUG:
> +            info.si_signo = TARGET_SIGTRAP;
> +            info.si_errno = 0;
> +            info.si_code = TARGET_TRAP_BRKPT;
> +            queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
> +            break;
>          case 0xaa:
>              switch (env->regs[R_PC]) {
>              /*case 0x1000:*/  /* TODO:__kuser_helper_version */
> 

  reply	other threads:[~2019-02-13 20:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 16:50 [Qemu-devel] [PATCH] Fix breakpoint support in Nios II user-mode emulation Sandra Loosemore
2019-02-13 20:46 ` Laurent Vivier [this message]
2019-02-25  5:05   ` [Qemu-devel] [ping] " Sandra Loosemore
2019-02-25  9:10 ` [Qemu-devel] " Peter Maydell
2019-02-25 10:14 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a48ece75-537d-72e9-8851-bc7a801f77af@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=crwulff@gmail.com \
    --cc=marex@denx.de \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=sandra@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).