From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eZeov-0002T2-U1 for qemu-devel@nongnu.org; Thu, 11 Jan 2018 10:31:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eZeoq-0004tA-Cd for qemu-devel@nongnu.org; Thu, 11 Jan 2018 10:31:09 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:43656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eZeoq-0004sV-7K for qemu-devel@nongnu.org; Thu, 11 Jan 2018 10:31:04 -0500 Received: by mail-pf0-x244.google.com with SMTP id e3so1889053pfi.10 for ; Thu, 11 Jan 2018 07:31:04 -0800 (PST) References: <1515637324-96034-1-git-send-email-mjc@sifive.com> <1515637324-96034-7-git-send-email-mjc@sifive.com> From: Richard Henderson Message-ID: Date: Thu, 11 Jan 2018 07:31:00 -0800 MIME-Version: 1.0 In-Reply-To: <1515637324-96034-7-git-send-email-mjc@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 06/21] RISC-V FPU Support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Clark , qemu-devel@nongnu.org Cc: Bastian Koppelmann , Palmer Dabbelt , Sagar Karandikar , RISC-V Patches On 01/10/2018 06:21 PM, Michael Clark wrote: > Helper routines for FPU instructions and NaN definitions. > > Signed-off-by: Michael Clark > --- > fpu/softfloat-specialize.h | 7 +- > target/riscv/fpu_helper.c | 591 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 595 insertions(+), 3 deletions(-) > create mode 100644 target/riscv/fpu_helper.c It doesn't look like you have addressed any of my comments against v1 here. r~