From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Bharata B Rao <bharata@linux.vnet.ibm.com>,
qemu-devel@nongnu.org, mjrosato@linux.vnet.ibm.com,
thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com,
aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de,
borntraeger@de.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com,
mdroth@linux.vnet.ibm.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit()
Date: Fri, 27 May 2016 11:51:20 +0200 [thread overview]
Message-ID: <a490e22e-1693-ab02-96ac-888813b85f92@redhat.com> (raw)
In-Reply-To: <20160527030736.GR17226@voom.fritz.box>
On 27/05/2016 05:07, David Gibson wrote:
> On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 12/05/2016 05:48, Bharata B Rao wrote:
>>> CPUState *cpu gets added to the cpus list during cpu_exec_init(). It
>>> should be removed from cpu_exec_exit().
>>>
>>> cpu_exec_exit() is called from generic CPU::instance_finalize and some
>>> archs like PowerPC call it from CPU unrealizefn. So ensure that we
>>> dequeue the cpu only once.
>>
>> I think the better thing would be to call it from CPU::unrealize, but
>> this patch is okay too.
>>
>> Thanks,
>>
>> Paolo
>
> Thanks for the review Paolo.
>
> However, what I'm really unclear on is what is the next step towards
> merging these. Will you take them through your tree? Should Bharata
> send a formal pull request with the prelim patches? If so, to whom?
Feel free to take them and add an Acked-by for me. The fewer patches I
merge, the better. :)
Thanks,
Paolo
next prev parent reply other threads:[~2016-05-27 9:51 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 3:48 [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR Bharata B Rao
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() Bharata B Rao
2016-05-26 10:12 ` Paolo Bonzini
2016-05-27 3:07 ` David Gibson
2016-05-27 9:51 ` Paolo Bonzini [this message]
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 02/15] exec: Do vmstate unregistration from cpu_exec_exit() Bharata B Rao
2016-05-26 10:22 ` Paolo Bonzini
2016-05-30 15:22 ` [Qemu-devel] [PATCH] fixup! " Igor Mammedov
2016-05-31 0:02 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects Bharata B Rao
2016-05-26 10:19 ` Paolo Bonzini
2016-05-26 10:47 ` Bharata B Rao
[not found] ` <201605261048.u4QAibq4039252@mx0a-001b2d01.pphosted.com>
2016-05-26 10:51 ` Paolo Bonzini
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove() Bharata B Rao
2016-05-26 10:22 ` Paolo Bonzini
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback Bharata B Rao
2016-06-02 1:15 ` David Gibson
2016-06-02 9:32 ` Igor Mammedov
2016-06-03 5:10 ` David Gibson
2016-06-03 9:23 ` Igor Mammedov
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type Bharata B Rao
2016-06-02 3:38 ` David Gibson
2016-06-02 9:35 ` Igor Mammedov
2016-06-02 18:12 ` Eduardo Habkost
2016-06-03 5:06 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 07/15] spapr: Abstract CPU core device and type specific core devices Bharata B Rao
2016-06-03 5:25 ` David Gibson
2016-06-08 9:42 ` Bharata B Rao
2016-06-09 0:45 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU " Bharata B Rao
2016-06-03 5:32 ` David Gibson
2016-06-08 12:23 ` Bharata B Rao
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 09/15] spapr: CPU hotplug support Bharata B Rao
2016-06-03 6:10 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 10/15] xics, xics_kvm: Handle CPU unplug correctly Bharata B Rao
2016-06-03 6:14 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR Bharata B Rao
2016-06-03 6:17 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 12/15] spapr: CPU hot unplug support Bharata B Rao
2016-06-03 6:27 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus Bharata B Rao
2016-06-06 5:28 ` David Gibson
2016-06-06 8:42 ` Igor Mammedov
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 14/15] hmp: Add 'info hotpluggable-cpus' HMP command Bharata B Rao
2016-06-06 5:29 ` David Gibson
2016-05-12 3:48 ` [Qemu-devel] [for-2.7 PATCH v3 15/15] spapr: implement query-hotpluggable-cpus callback Bharata B Rao
2016-06-06 5:37 ` David Gibson
2016-05-25 6:54 ` [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR Thomas Huth
2016-05-25 16:03 ` Andreas Färber
2016-05-26 6:20 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a490e22e-1693-ab02-96ac-888813b85f92@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).