From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6EQX-0001h0-Bz for qemu-devel@nongnu.org; Fri, 27 May 2016 05:51:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6EQT-00038t-DG for qemu-devel@nongnu.org; Fri, 27 May 2016 05:51:33 -0400 References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com> <1463024905-28401-2-git-send-email-bharata@linux.vnet.ibm.com> <4d2629df-500b-f5b3-e3b0-5b377c16454a@redhat.com> <20160527030736.GR17226@voom.fritz.box> From: Paolo Bonzini Message-ID: Date: Fri, 27 May 2016 11:51:20 +0200 MIME-Version: 1.0 In-Reply-To: <20160527030736.GR17226@voom.fritz.box> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Bharata B Rao , qemu-devel@nongnu.org, mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de On 27/05/2016 05:07, David Gibson wrote: > On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote: >> >> >> On 12/05/2016 05:48, Bharata B Rao wrote: >>> CPUState *cpu gets added to the cpus list during cpu_exec_init(). It >>> should be removed from cpu_exec_exit(). >>> >>> cpu_exec_exit() is called from generic CPU::instance_finalize and som= e >>> archs like PowerPC call it from CPU unrealizefn. So ensure that we >>> dequeue the cpu only once. >> >> I think the better thing would be to call it from CPU::unrealize, but >> this patch is okay too. >> >> Thanks, >> >> Paolo >=20 > Thanks for the review Paolo. >=20 > However, what I'm really unclear on is what is the next step towards > merging these. Will you take them through your tree? Should Bharata > send a formal pull request with the prelim patches? If so, to whom? Feel free to take them and add an Acked-by for me. The fewer patches I merge, the better. :) Thanks, Paolo