* [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()
@ 2023-04-24 12:21 Thomas Huth
2023-04-24 13:08 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2023-04-24 12:21 UTC (permalink / raw)
To: qemu-devel, Laurent Vivier; +Cc: qemu-trivial
This way we can get rid of the if'deffery and the XXX comment
here (it's repeated in the list_cpus() function anyway).
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
linux-user/main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index fe03293516..aece4d9e91 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -359,10 +359,7 @@ static void handle_arg_cpu(const char *arg)
{
cpu_model = strdup(arg);
if (cpu_model == NULL || is_help_option(cpu_model)) {
- /* XXX: implement xxx_cpu_list for targets that still miss it */
-#if defined(cpu_list)
- cpu_list();
-#endif
+ list_cpus();
exit(EXIT_FAILURE);
}
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()
2023-04-24 12:21 [PATCH] linux-user/main: Use list_cpus() instead of cpu_list() Thomas Huth
@ 2023-04-24 13:08 ` Richard Henderson
2023-04-24 15:27 ` Philippe Mathieu-Daudé
2023-05-01 15:41 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Richard Henderson @ 2023-04-24 13:08 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier; +Cc: qemu-trivial
On 4/24/23 13:21, Thomas Huth wrote:
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> linux-user/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()
2023-04-24 12:21 [PATCH] linux-user/main: Use list_cpus() instead of cpu_list() Thomas Huth
2023-04-24 13:08 ` Richard Henderson
@ 2023-04-24 15:27 ` Philippe Mathieu-Daudé
2023-05-01 15:41 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-24 15:27 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Laurent Vivier; +Cc: qemu-trivial
On 24/4/23 14:21, Thomas Huth wrote:
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> linux-user/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()
2023-04-24 12:21 [PATCH] linux-user/main: Use list_cpus() instead of cpu_list() Thomas Huth
2023-04-24 13:08 ` Richard Henderson
2023-04-24 15:27 ` Philippe Mathieu-Daudé
@ 2023-05-01 15:41 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2023-05-01 15:41 UTC (permalink / raw)
To: Thomas Huth, qemu-devel; +Cc: qemu-trivial
Le 24/04/2023 à 14:21, Thomas Huth a écrit :
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> linux-user/main.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index fe03293516..aece4d9e91 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -359,10 +359,7 @@ static void handle_arg_cpu(const char *arg)
> {
> cpu_model = strdup(arg);
> if (cpu_model == NULL || is_help_option(cpu_model)) {
> - /* XXX: implement xxx_cpu_list for targets that still miss it */
> -#if defined(cpu_list)
> - cpu_list();
> -#endif
> + list_cpus();
> exit(EXIT_FAILURE);
> }
> }
Applied to my linux-user-for-8.1 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-01 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-24 12:21 [PATCH] linux-user/main: Use list_cpus() instead of cpu_list() Thomas Huth
2023-04-24 13:08 ` Richard Henderson
2023-04-24 15:27 ` Philippe Mathieu-Daudé
2023-05-01 15:41 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).