From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: philmd@redhat.com
Subject: Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds
Date: Wed, 16 Dec 2020 16:22:07 +0100 [thread overview]
Message-ID: <a4974b10-ba71-8bd7-e5a9-6eef7543cee4@redhat.com> (raw)
In-Reply-To: <98e787e4-884b-61c5-bf52-b041f57747c3@linaro.org>
On 16/12/20 16:13, Richard Henderson wrote:
>> @@ -71,7 +71,7 @@ foreach d : [
>> input: meson.project_source_root() / 'trace-events',
>> command: [ tracetool, '--group=root', '--format=@0@'.format(d[1]), '@INPUT@' ],
>> capture: true)
>> - specific_ss.add(gen)
>> + specific_ss.add(when: 'CONFIG_TCG', if_true: gen)
>> endforeach
>
> Sure, unless it makes more sense to conditionalize the entire loop, so that
> those targets aren't even created?
The targets exist but the files won't be created (the rules will be in
build.ninja but they'll be orphan).
Paolo
next prev parent reply other threads:[~2020-12-16 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 13:55 [PATCH 0/3] Cleanup includes for no-TCG builds Paolo Bonzini
2020-12-16 13:55 ` [PATCH 1/3] remove TCG includes from common code Paolo Bonzini
2020-12-16 15:10 ` Richard Henderson
2020-12-16 15:36 ` Philippe Mathieu-Daudé
2020-12-16 13:55 ` [PATCH 2/3] move icache flush out of tcg.h Paolo Bonzini
2020-12-16 14:52 ` Richard Henderson
2020-12-16 14:57 ` Paolo Bonzini
2020-12-16 13:55 ` [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds Paolo Bonzini
2020-12-16 15:13 ` Richard Henderson
2020-12-16 15:22 ` Paolo Bonzini [this message]
2020-12-16 15:25 ` Richard Henderson
2020-12-16 15:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4974b10-ba71-8bd7-e5a9-6eef7543cee4@redhat.com \
--to=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).