From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4378EC282E3 for ; Sun, 26 May 2019 13:52:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18D8D2075E for ; Sun, 26 May 2019 13:52:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D8D2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:55655 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUtZz-00018N-7p for qemu-devel@archiver.kernel.org; Sun, 26 May 2019 09:52:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hUtYj-0000YF-BV for qemu-devel@nongnu.org; Sun, 26 May 2019 09:51:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hUtYf-0001hV-0T for qemu-devel@nongnu.org; Sun, 26 May 2019 09:51:31 -0400 Received: from mga02.intel.com ([134.134.136.20]:2242) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hUtYe-0001BL-3J; Sun, 26 May 2019 09:51:28 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 May 2019 06:51:15 -0700 Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.255.31.212]) ([10.255.31.212]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 26 May 2019 06:51:13 -0700 From: Like Xu To: qemu-trivial@nongnu.org References: <20190518205428.90532-1-like.xu@linux.intel.com> Organization: Intel OTC Message-ID: Date: Sun, 26 May 2019 21:51:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190518205428.90532-1-like.xu@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.20 Subject: Re: [Qemu-devel] [PATCH v3 00/10] Refactor cpu topo into machine properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , "Dr . David Alan Gilbert" , qemu-devel@nongnu.org, Alistair Francis , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2019/5/19 4:54, Like Xu wrote: > This patch series make existing cores/threads/sockets into machine > properties and get rid of global smp_* variables they use currently. > > The purpose of getting rid of globals is disentangle layer violations and > let's do it one step at a time by replacing the smp_foo with qdev_get_machine() > as few calls as possible and delay other related refactoring efforts. > Hi Eduardo & Igor, Do you have any comments on this new version of CpuTopology refactoring? With this series of patch, we may move forward to review [Qemu-devel] [PATCH v2 0/5] Introduce cpu die topology and enable CPUID.1F for i386. Thanks, Like Xu > ==changelog== > > v3: > > - rephrase commit messages > - s/of/of present/ for CpuTopology comment > - drop reduanct arguments such as cpu_type > - use ms instead of macs in migration context > - rebase to commit 1b46b4daa6 >