From: Richard Henderson <richard.henderson@linaro.org>
To: Pierrick Bouvier <pierrick.bouvier@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 22/39] target/i386/kvm: replace assert(false) with g_assert_not_reached()
Date: Tue, 10 Sep 2024 20:27:45 -0700 [thread overview]
Message-ID: <a4b5729a-ac10-4035-992a-926fa7124f8f@linaro.org> (raw)
In-Reply-To: <20240910221606.1817478-23-pierrick.bouvier@linaro.org>
On 9/10/24 15:15, Pierrick Bouvier wrote:
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> target/i386/kvm/kvm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index 2fa88ef1e37..308b0e1cb37 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -5770,7 +5770,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run)
> }
> }
>
> - assert(false);
> + g_assert_not_reached();
> }
>
> static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run)
> @@ -5789,7 +5789,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run)
> }
> }
>
> - assert(false);
> + g_assert_not_reached();
> }
>
> static bool has_sgx_provisioning;
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-09-11 3:28 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 22:15 [PATCH 00/39] Use g_assert_not_reached instead of (g_)assert(0, false) Pierrick Bouvier
2024-09-10 22:15 ` [PATCH 01/39] docs/spin: replace assert(0) with g_assert_not_reached() Pierrick Bouvier
2024-09-11 1:36 ` Richard Henderson
2024-09-11 12:33 ` Eric Blake
2024-09-11 12:37 ` Eric Blake
2024-09-11 12:46 ` Maciej S. Szmigiero
2024-09-11 12:51 ` Richard W.M. Jones
2024-09-11 15:25 ` Pierrick Bouvier
2024-09-11 16:55 ` Richard Henderson
2024-09-11 16:13 ` Thomas Huth
2024-09-12 0:28 ` Pierrick Bouvier
2024-09-11 15:23 ` Pierrick Bouvier
2024-09-10 22:15 ` [PATCH 02/39] hw/acpi: " Pierrick Bouvier
2024-09-11 1:37 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 03/39] hw/arm: " Pierrick Bouvier
2024-09-11 1:38 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 04/39] hw/char: " Pierrick Bouvier
2024-09-11 1:39 ` Richard Henderson
2024-09-11 6:11 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 05/39] hw/core: " Pierrick Bouvier
2024-09-11 1:43 ` Richard Henderson
2024-09-11 6:12 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 06/39] hw/net: " Pierrick Bouvier
2024-09-11 2:06 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 07/39] hw/watchdog: " Pierrick Bouvier
2024-09-11 2:14 ` Richard Henderson
2024-09-11 6:12 ` Philippe Mathieu-Daudé
2024-09-11 8:35 ` Richard W.M. Jones
2024-09-10 22:15 ` [PATCH 08/39] migration: " Pierrick Bouvier
2024-09-10 22:25 ` Fabiano Rosas
2024-09-11 2:17 ` Richard Henderson
2024-09-11 2:37 ` Pierrick Bouvier
2024-09-11 13:40 ` Peter Xu
2024-09-10 22:15 ` [PATCH 09/39] qobject: " Pierrick Bouvier
2024-09-11 3:12 ` Richard Henderson
2024-09-11 16:56 ` Kevin Wolf
2024-09-10 22:15 ` [PATCH 10/39] system: " Pierrick Bouvier
2024-09-11 3:13 ` Richard Henderson
2024-09-11 6:12 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 11/39] target/ppc: " Pierrick Bouvier
2024-09-11 3:14 ` Richard Henderson
2024-09-11 15:27 ` Pierrick Bouvier
2024-09-11 9:40 ` Daniel Henrique Barboza
2024-09-10 22:15 ` [PATCH 12/39] tests/qtest: " Pierrick Bouvier
2024-09-11 3:17 ` Richard Henderson
2024-09-11 5:43 ` Thomas Huth
2024-09-10 22:15 ` [PATCH 13/39] tests/unit: " Pierrick Bouvier
2024-09-11 3:19 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 14/39] include/hw/s390x: replace assert(false) " Pierrick Bouvier
2024-09-11 3:19 ` Richard Henderson
2024-09-11 5:42 ` Thomas Huth
2024-09-10 22:15 ` [PATCH 15/39] block: " Pierrick Bouvier
2024-09-11 3:20 ` Richard Henderson
2024-09-11 15:47 ` Kevin Wolf
2024-09-10 22:15 ` [PATCH 16/39] hw/hyperv: " Pierrick Bouvier
2024-09-11 3:21 ` Richard Henderson
2024-09-11 10:17 ` Maciej S. Szmigiero
2024-09-10 22:15 ` [PATCH 17/39] hw/net: " Pierrick Bouvier
2024-09-11 3:21 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 18/39] hw/nvme: " Pierrick Bouvier
2024-09-11 3:22 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 19/39] hw/pci: " Pierrick Bouvier
2024-09-11 3:22 ` Richard Henderson
2024-09-11 5:50 ` Philippe Mathieu-Daudé
2024-09-11 15:29 ` Pierrick Bouvier
2024-09-10 22:15 ` [PATCH 20/39] hw/ppc: " Pierrick Bouvier
2024-09-11 3:26 ` Richard Henderson
2024-09-11 9:41 ` Daniel Henrique Barboza
2024-09-11 14:10 ` BALATON Zoltan
2024-09-11 15:32 ` Pierrick Bouvier
2024-09-11 16:08 ` BALATON Zoltan
2024-09-10 22:15 ` [PATCH 21/39] migration: " Pierrick Bouvier
2024-09-10 22:26 ` Fabiano Rosas
2024-09-11 3:26 ` Richard Henderson
2024-09-11 3:27 ` Richard Henderson
2024-09-11 13:40 ` Peter Xu
2024-09-10 22:15 ` [PATCH 22/39] target/i386/kvm: " Pierrick Bouvier
2024-09-11 3:27 ` Richard Henderson [this message]
2024-09-10 22:15 ` [PATCH 23/39] tests/qtest: " Pierrick Bouvier
2024-09-11 3:28 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 24/39] accel/tcg: remove break after g_assert_not_reached() Pierrick Bouvier
2024-09-11 3:28 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 25/39] block: " Pierrick Bouvier
2024-09-11 3:29 ` Richard Henderson
2024-09-11 8:35 ` Richard W.M. Jones
2024-09-11 15:53 ` Kevin Wolf
2024-09-10 22:15 ` [PATCH 26/39] hw/acpi: " Pierrick Bouvier
2024-09-11 3:30 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 27/39] hw/gpio: " Pierrick Bouvier
2024-09-11 3:29 ` Richard Henderson
2024-09-11 6:12 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 28/39] hw/misc: " Pierrick Bouvier
2024-09-11 3:31 ` Richard Henderson
2024-09-11 6:13 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 29/39] hw/net: " Pierrick Bouvier
2024-09-11 3:31 ` Richard Henderson
2024-09-10 22:15 ` [PATCH 30/39] hw/pci-host: " Pierrick Bouvier
2024-09-11 3:32 ` Richard Henderson
2024-09-11 6:13 ` Philippe Mathieu-Daudé
2024-09-10 22:15 ` [PATCH 31/39] hw/scsi: " Pierrick Bouvier
2024-09-11 3:33 ` Richard Henderson
2024-09-11 15:56 ` Kevin Wolf
2024-09-10 22:15 ` [PATCH 32/39] hw/tpm: " Pierrick Bouvier
2024-09-11 3:33 ` Richard Henderson
2024-09-10 22:16 ` [PATCH 33/39] target/arm: " Pierrick Bouvier
2024-09-11 3:33 ` Richard Henderson
2024-09-10 22:16 ` [PATCH 34/39] target/riscv: " Pierrick Bouvier
2024-09-11 3:34 ` Richard Henderson
2024-09-11 9:35 ` Daniel Henrique Barboza
2024-09-10 22:16 ` [PATCH 35/39] tests/qtest: " Pierrick Bouvier
2024-09-11 3:34 ` Richard Henderson
2024-09-10 22:16 ` [PATCH 36/39] ui: " Pierrick Bouvier
2024-09-11 3:34 ` Richard Henderson
2024-09-11 6:13 ` Philippe Mathieu-Daudé
2024-09-10 22:16 ` [PATCH 37/39] fpu: " Pierrick Bouvier
2024-09-11 3:35 ` Richard Henderson
2024-09-10 22:16 ` [PATCH 38/39] tcg/loongarch64: " Pierrick Bouvier
2024-09-11 3:35 ` Richard Henderson
2024-09-10 22:16 ` [PATCH 39/39] scripts/checkpatch.pl: emit error when using assert(false) Pierrick Bouvier
2024-09-11 3:35 ` Richard Henderson
2024-09-11 8:39 ` [PATCH 00/39] Use g_assert_not_reached instead of (g_)assert(0,false) Philippe Mathieu-Daudé
2024-09-11 15:34 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4b5729a-ac10-4035-992a-926fa7124f8f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).