From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHeV-00015x-97 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 08:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVHeQ-0006DD-0Y for qemu-devel@nongnu.org; Thu, 04 Aug 2016 08:21:30 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:26796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVHeP-0006Ca-R6 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 08:21:25 -0400 From: Paul Durrant Date: Thu, 4 Aug 2016 12:14:10 +0000 Message-ID: References: <1470150402-20302-1-git-send-email-paul.durrant@citrix.com> <20160804120354.GJ14185@stefanha-x1.localdomain> In-Reply-To: <20160804120354.GJ14185@stefanha-x1.localdomain> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] trace: add syslog tracing backend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "qemu-devel@nongnu.org" > -----Original Message----- > From: Stefan Hajnoczi [mailto:stefanha@redhat.com] > Sent: 04 August 2016 13:04 > To: Paul Durrant > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH] trace: add syslog tracing backend >=20 > On Tue, Aug 02, 2016 at 04:06:42PM +0100, Paul Durrant wrote: > > This patch adds a tracing backend which sends output using syslog(). > > The syslog backend is limited to POSIX compliant systems. > > > > openlog() is called with facility set to LOG_DAEMON, with the LOG_PID > > option. Trace events are logged at level LOG_INFO. > > > > Signed-off-by: Paul Durrant > > Cc: Stefan Hajnoczi > > --- > > configure | 19 ++++++++++++++++ > > scripts/tracetool/backend/syslog.py | 45 > +++++++++++++++++++++++++++++++++++++ > > trace/control.c | 7 ++++++ > > 3 files changed, 71 insertions(+) > > create mode 100644 scripts/tracetool/backend/syslog.py >=20 > Please add a section to docs/tracing.txt. It's worth mentioning the > caveats that Daniel Berrange pointed out in the documentation. Sure. Will do. >=20 > (I do believe that syslog tracing can be useful in some cases and it > will be merged.) >=20 > > +def generate_h_begin(events): > > + out('#include "trace/control.h"', > > + '#include ', >=20 > Please include system headers before user headers. This makes it clear > the user headers are not defining macros that will affect system > headers (which is sometimes necessary but should be done explicitly). Ok. Cheers, Paul