From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] python, tests: do not use short-form boolean options
Date: Tue, 17 Nov 2020 12:08:27 +0100 [thread overview]
Message-ID: <a4c8c4c9-c9ed-4043-c257-993caeee29ed@redhat.com> (raw)
In-Reply-To: <87v9e49w5s.fsf@dusky.pond.sub.org>
On 17/11/20 10:20, Markus Armbruster wrote:
>> - chardev = ('socket,id=console,path=%s,server,nowait' %
>> + chardev = ('socket,id=console,path=%s,server=yes,wait=no' %
>
> Let's stick to the canonical 'on' and 'off'.
That was on purpose (for extra coverage and not just because variety is
the spice of life). But I can use the canonical values as well if you
prefer.
Paolo
>> self._console_address)
>> args.extend(['-chardev', chardev])
>> if self._console_device_type is None:
> [More of the same...]
>
next prev parent reply other threads:[~2020-11-17 11:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 15:20 [PATCH] python, tests: do not use short-form boolean options Paolo Bonzini
2020-11-17 9:20 ` Markus Armbruster
2020-11-17 11:08 ` Paolo Bonzini [this message]
2020-11-17 14:32 ` Markus Armbruster
2020-12-07 19:17 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4c8c4c9-c9ed-4043-c257-993caeee29ed@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).