From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C70C5519F for ; Tue, 17 Nov 2020 11:10:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEF7A207BC for ; Tue, 17 Nov 2020 11:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hFCnCPnY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEF7A207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keys4-0004ou-RA for qemu-devel@archiver.kernel.org; Tue, 17 Nov 2020 06:10:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keyqk-0003h8-OA for qemu-devel@nongnu.org; Tue, 17 Nov 2020 06:08:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45596) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1keyqi-00032s-NX for qemu-devel@nongnu.org; Tue, 17 Nov 2020 06:08:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605611314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4N8kfNNa/UVNsjQUdQQjlzs8wVkFY65O566zczNrsd4=; b=hFCnCPnYfv9WzImwcU0ffCQQ5+3ptw0qGORWLMWnS/nTe76FLmz91XRQYRNwfsF41+DOSN ny6JnEYav3YkvEnC+fZ8OXfUw35pT2k6C82LLD45iYqSaewOvMD14O0xyHMPZu57zjQBIJ 8BN6MsaQ8D1aq0iWU84xWeEtaYyIKwM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-Bd9gI5CQP4Ci6z2n8_OELA-1; Tue, 17 Nov 2020 06:08:31 -0500 X-MC-Unique: Bd9gI5CQP4Ci6z2n8_OELA-1 Received: by mail-wr1-f72.google.com with SMTP id c8so12890342wrh.16 for ; Tue, 17 Nov 2020 03:08:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4N8kfNNa/UVNsjQUdQQjlzs8wVkFY65O566zczNrsd4=; b=XB0J8vtVt12MM/Y0Ow6DMmvipitTDTCutc95LnnfTQfiwl435heKv+kVRAG0R/PVUs Bf8UcrRlmtl8cH0e6yeN5qRMLuKdkWh/aEUVXAtM4v1KiiIssMm34COj2X/qZ+8piH2F tcm5tgeNAPtvCWi1/zJrjiZcq1KH0USL6+iyX/hHfOwxK599SNKmmqDyb98PYHm9Dkaa w40PaDYmB53OxTTpx339kGnuPeTMbSXknQG/mezBiPv2FoqcASdH5Mh9xYCJNTDryl49 +5w9gM4yPmn/ymxE0vacoHytsh98U7lzDEa/9zggJQzjGYYwos+O4XEP2sTiKsM1WIil kQwg== X-Gm-Message-State: AOAM533mAcHTM73eqiC0npFCY3BC6/0xSMFPsOhFljj/ScQFywOOORXw btWxpWr6sOq9sk63UobdtZKlN5Vc/8dWTt5oUlO5QMZr+6vy7Y1g6DOkrhUowR6RGc0PxCI80LQ W5EX3o7Y3HutwQrtVLoSJLBZz19xGlFcPbq0kYvZJNfd9OX/B/crG29qHY3yTeCLhabI= X-Received: by 2002:a7b:c1ce:: with SMTP id a14mr3598930wmj.169.1605611309455; Tue, 17 Nov 2020 03:08:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLK5x0GzapnXO/fed5KqSrMJXH6sYzOmLnP35UhYRxIJok1bYYGXC3BvR+PfgvOaa3FY1bNg== X-Received: by 2002:a7b:c1ce:: with SMTP id a14mr3598905wmj.169.1605611309173; Tue, 17 Nov 2020 03:08:29 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id 90sm6737411wrl.60.2020.11.17.03.08.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 03:08:28 -0800 (PST) Subject: Re: [PATCH] python, tests: do not use short-form boolean options To: Markus Armbruster References: <20201113152035.1459107-1-pbonzini@redhat.com> <87v9e49w5s.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: Date: Tue, 17 Nov 2020 12:08:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <87v9e49w5s.fsf@dusky.pond.sub.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/17 01:18:45 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 17/11/20 10:20, Markus Armbruster wrote: >> - chardev = ('socket,id=console,path=%s,server,nowait' % >> + chardev = ('socket,id=console,path=%s,server=yes,wait=no' % > > Let's stick to the canonical 'on' and 'off'. That was on purpose (for extra coverage and not just because variety is the spice of life). But I can use the canonical values as well if you prefer. Paolo >> self._console_address) >> args.extend(['-chardev', chardev]) >> if self._console_device_type is None: > [More of the same...] >