qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: kvm@vger.kernel.org
Cc: aliguori@us.ibm.com, mst@redhat.com, jan.kiszka@siemens.com,
	qemu-devel@nongnu.org, alex.williamson@redhat.com,
	avi@redhat.com
Subject: [Qemu-devel] [PATCH 2/2] qemu kvm: add better error reporting when kvm_get_irq_route_gsi() fails
Date: Tue, 27 Mar 2012 17:00:30 -0400	[thread overview]
Message-ID: <a4d2719d9c53b7fbf4edf2a05baaea53ed1a3d65.1332881354.git.jbaron@redhat.com> (raw)
In-Reply-To: <cover.1332881354.git.jbaron@redhat.com>

When kvm_get_irq_route_gsi() fails in assigned_dev_update_msix_mmio, it
would be nice to have a better error message.

Signed-off-by: Jason Baron <jbaron@redhat.com>
---
 hw/device-assignment.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 89823f1..d017537 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1023,8 +1023,10 @@ static int assigned_dev_update_msix_mmio(PCIDevice *pci_dev)
         }
 
         r = kvm_get_irq_route_gsi();
-        if (r < 0)
+        if (r < 0) {
+            perror("assigned_dev_update_msix_mmio: kvm_get_irq_route_gsi");
             return r;
+        }
 
         adev->entry[i].gsi = r;
         adev->entry[i].type = KVM_IRQ_ROUTING_MSI;
-- 
1.7.1

      parent reply	other threads:[~2012-03-27 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27 21:00 [Qemu-devel] [PATCH 0/2] qemu kvm: correct gsi bitmap Jason Baron
2012-03-27 21:00 ` [Qemu-devel] [PATCH 1/2] qemu kvm: Set up gsi bitmap correctly Jason Baron
2012-03-27 21:31   ` Alex Williamson
2012-03-27 22:01     ` Jan Kiszka
2012-03-27 22:25       ` Alex Williamson
2012-03-27 22:32         ` Jan Kiszka
2012-03-27 21:52   ` Jan Kiszka
2012-03-27 21:00 ` Jason Baron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4d2719d9c53b7fbf4edf2a05baaea53ed1a3d65.1332881354.git.jbaron@redhat.com \
    --to=jbaron@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).