qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cole Robinson <crobinso@redhat.com>
To: qemu-devel@nongnu.org
Cc: Cole Robinson <crobinso@redhat.com>
Subject: [PATCH 4/4] contrib: qemu-guest-agent.service: Use IgnoreOnIsolate=True
Date: Thu,  8 Jul 2021 14:32:02 -0400	[thread overview]
Message-ID: <a4e48006fe2e705c40bea7a45c9142250dd63651.1625769000.git.crobinso@redhat.com> (raw)
In-Reply-To: <cover.1625769000.git.crobinso@redhat.com>

Changing runlevel (telinit 3) will stop qemu-guest-agent.service, and
it won't ever restart, because it's intended to only start when the
specified virtio device is added.

Use IgnoreOnIsolate=True plus Install WantedBy= to keep the agent
running regardless of runlevel, which is the expected behavior IMO.

This has been in RHEL since 7.2ish timeframe:
https://bugzilla.redhat.com/show_bug.cgi?id=1165176

Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 contrib/systemd/qemu-guest-agent.service | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/contrib/systemd/qemu-guest-agent.service b/contrib/systemd/qemu-guest-agent.service
index 505636a5ba..bb419fe55f 100644
--- a/contrib/systemd/qemu-guest-agent.service
+++ b/contrib/systemd/qemu-guest-agent.service
@@ -3,6 +3,7 @@ Description=QEMU Guest Agent
 Documentation=https://wiki.qemu.org/Features/GuestAgent
 BindsTo=dev-virtio\x2dports-org.qemu.guest_agent.0.device
 After=dev-virtio\x2dports-org.qemu.guest_agent.0.device
+IgnoreOnIsolate=True
 
 [Service]
 ExecStart=/usr/bin/qemu-ga
@@ -10,3 +11,4 @@ Restart=always
 RestartSec=0
 
 [Install]
+WantedBy=dev-virtio\x2dports-org.qemu.guest_agent.0.device
-- 
2.31.1



      parent reply	other threads:[~2021-07-08 18:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 18:31 [PATCH 0/4] contrib: qemu-guest-agent.service updates Cole Robinson
2021-07-08 18:31 ` [PATCH 1/4] contrib: qemu-guest-agent.service: s/BindTo/BindsTo/g Cole Robinson
2021-07-08 18:32 ` [PATCH 2/4] contrib: qemu-guest-agent.service: Add Documentation= link Cole Robinson
2021-07-08 18:32 ` [PATCH 3/4] contrib: qemu-guest-agent.service: Don't ignore failure Cole Robinson
2021-07-08 18:32 ` Cole Robinson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4e48006fe2e705c40bea7a45c9142250dd63651.1625769000.git.crobinso@redhat.com \
    --to=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).