From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Roman Bolshakov <r.bolshakov@yadro.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v28 00/23] i386 cleanup PART 2
Date: Thu, 8 Apr 2021 15:38:24 +0200 [thread overview]
Message-ID: <a4f356eb-4e5d-d9f1-d2f3-e5e13e0eae4f@redhat.com> (raw)
In-Reply-To: <eb692e31-72b6-1ba4-f784-6cc7d0993907@redhat.com>
Hi Paolo,
On 3/22/21 5:41 PM, Paolo Bonzini wrote:
> Looks good to me, thanks for all the effort!
>
> Paolo
>
> On 22/03/21 14:27, Claudio Fontana wrote:
>> v27 -> v28:
>>
>> * rebased on latest master;
>> I indicated the conflicts for the affected patches in the commit
>> message,
>> in case a new review/eye is required.
>>
>> * added three patches:
>> - accel: move call to accel_init_interfaces
>>
>> This matches more closely the initialization phases definitions
>> (Paolo)
>>
>> - accel: add init_accel_cpu for adapting accel behavior to cpu type
>> This in particular is useful for ARM, that needs different TCG
>> behavior
>> depending on the CPU subclass.
>>
>> - XXX RFC accel: add cpu_reset
>>
>> This adds an accel cpu behavior to execute after CPU reset.
>> This can be used on x86, arm, s390x, mips for KVM and TCG.
>>
>> The RFC nature of this has to do with the fact that cpu_reset()
>> remains
>> in hw/core/cpu.c , which is common_ss,
>> and cpu_reset() calls accel_cpu_reset() which is in specific_ss.
>> So it seems weird that this builds fine, and all tests seem
>> to pass,
>> without using a specific_ss call.
What about this cpu_reset() part?
>>
>>
>> v26 -> v27: rebased on latest master
prev parent reply other threads:[~2021-04-08 13:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 13:27 [PATCH v28 00/23] i386 cleanup PART 2 Claudio Fontana
2021-03-22 13:27 ` [RFC] accel: add cpu_reset Claudio Fontana
2021-03-22 13:31 ` Paolo Bonzini
2021-03-22 13:35 ` Claudio Fontana
2021-03-22 13:45 ` Paolo Bonzini
2021-03-22 13:51 ` Claudio Fontana
2021-03-23 7:55 ` Paolo Bonzini
2021-03-22 13:42 ` Philippe Mathieu-Daudé
2021-03-22 13:54 ` Claudio Fontana
2021-03-23 8:43 ` Philippe Mathieu-Daudé
2021-03-22 13:27 ` [PATCH v28 01/23] target/i386: Rename helper_fldt, helper_fstt Claudio Fontana
2021-03-22 15:58 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 02/23] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor Claudio Fontana
2021-03-22 16:14 ` Alex Bennée
2021-03-22 13:27 ` [PATCH v28 03/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 04/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 05/23] accel: introduce new accessor functions Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 06/23] target/i386: fix host_cpu_adjust_phys_bits error handling Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 07/23] accel-cpu: make cpu_realizefn return a bool Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 08/23] meson: add target_user_arch Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 09/23] i386: split off sysemu-only functionality in tcg-cpu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 10/23] i386: split smm helper (sysemu) Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 11/23] i386: split tcg excp_helper into sysemu and user parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 12/23] i386: move TCG bpt_helper into sysemu/ Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 13/23] i386: split misc helper user stubs and sysemu part Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 14/23] i386: separate fpu_helper sysemu-only parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 15/23] i386: split svm_helper into sysemu and stub-only user Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 16/23] i386: split seg_helper into user-only and sysemu parts Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 17/23] i386: split off sysemu part of cpu.c Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 18/23] target/i386: gdbstub: introduce aux functions to read/write CS64 regs Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 19/23] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 20/23] i386: make cpu_load_efer sysemu-only Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 21/23] accel: move call to accel_init_interfaces Claudio Fontana
2021-03-22 13:27 ` [PATCH v28 22/23] accel: add init_accel_cpu for adapting accel behavior to CPU type Claudio Fontana
2021-03-22 13:28 ` [RFC v28 23/23] XXX RFC accel: add cpu_reset Claudio Fontana
2021-03-22 16:41 ` [PATCH v28 00/23] i386 cleanup PART 2 Paolo Bonzini
2021-04-08 13:38 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4f356eb-4e5d-d9f1-d2f3-e5e13e0eae4f@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).