From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com, mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments
Date: Mon, 14 Sep 2020 10:57:31 -0500 [thread overview]
Message-ID: <a5014641-6c47-d37f-c7c9-c862bf4e8217@redhat.com> (raw)
In-Reply-To: <20200914084802.4185028-8-armbru@redhat.com>
On 9/14/20 3:48 AM, Markus Armbruster wrote:
> This policy rejects deprecated input, and thus permits "testing the
> future". Implement it for QMP command arguments: reject commands with
> deprecated ones. Example: when QEMU is run with -compat
> deprecated-input=reject, then
>
> {"execute": "eject", "arguments": {"device": "cd"}}
>
> fails like this
>
> {"error": {"class": "GenericError", "desc": "Deprecated parameter 'device' disabled by policy"}}
>
> When the deprecated parameter is removed, the error will change to
>
> {"error": {"class": "GenericError", "desc": "Parameter 'device' is unexpected"}}
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-09-14 16:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 8:47 [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 1/8] qemu-options: New -compat to set policy for " Markus Armbruster
2020-09-14 11:50 ` Peter Krempa
2020-09-21 14:35 ` Markus Armbruster
2020-09-14 15:08 ` Eric Blake
2020-09-21 12:01 ` Richard W.M. Jones
2020-09-14 8:47 ` [PATCH v5 2/8] qapi: Implement deprecated-output=hide for QMP command results Markus Armbruster
2020-09-14 8:47 ` [PATCH v5 3/8] qapi: Implement deprecated-output=hide for QMP events Markus Armbruster
2020-09-14 15:19 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 4/8] qapi: Implement deprecated-output=hide for QMP event data Markus Armbruster
2020-09-14 15:35 ` Eric Blake
2020-09-14 8:47 ` [PATCH v5 5/8] qapi: Implement deprecated-output=hide for QMP introspection Markus Armbruster
2020-09-14 15:43 ` Eric Blake
2020-09-21 14:41 ` Markus Armbruster
2020-09-14 8:48 ` [PATCH v5 6/8] qapi: Implement deprecated-input=reject for QMP commands Markus Armbruster
2020-09-14 15:45 ` Eric Blake
2020-09-14 8:48 ` [PATCH v5 7/8] qapi: Implement deprecated-input=reject for QMP command arguments Markus Armbruster
2020-09-14 15:57 ` Eric Blake [this message]
2020-09-14 8:48 ` [PATCH v5 8/8] qapi: New -compat deprecated-input=crash Markus Armbruster
2020-09-14 15:58 ` Eric Blake
2020-09-21 14:42 ` Markus Armbruster
2020-09-21 12:45 ` [PATCH v5 0/8] Configurable policy for handling deprecated interfaces Richard W.M. Jones
2020-09-21 12:54 ` Peter Krempa
2020-09-21 12:58 ` Richard W.M. Jones
2020-09-21 12:56 ` Peter Maydell
2020-09-21 14:58 ` Markus Armbruster
2020-09-21 16:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5014641-6c47-d37f-c7c9-c862bf4e8217@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).