From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>, qemu-block@nongnu.org
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH v1] job.c: add missing notifier initialization
Date: Wed, 3 Nov 2021 17:32:15 +0100 [thread overview]
Message-ID: <a513fe14-5fa7-ac8e-8ef8-b165055e73d5@redhat.com> (raw)
In-Reply-To: <20211103162155.791482-1-eesposit@redhat.com>
On 11/3/21 17:21, Emanuele Giuseppe Esposito wrote:
> It seems that on_idle list is not properly initialized like
> the other notifiers.
>
Cc: qemu-stable@nongnu.org
Fixes: 34dc97b9a0e ("blockjob: Wake up BDS when job becomes idle")
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> job.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/job.c b/job.c
> index dbfa67bb0a..54db80df66 100644
> --- a/job.c
> +++ b/job.c
> @@ -352,6 +352,7 @@ void *job_create(const char *job_id, const JobDriver *driver, JobTxn *txn,
> notifier_list_init(&job->on_finalize_completed);
> notifier_list_init(&job->on_pending);
> notifier_list_init(&job->on_ready);
> + notifier_list_init(&job->on_idle);
>
> job_state_transition(job, JOB_STATUS_CREATED);
> aio_timer_init(qemu_get_aio_context(), &job->sleep_timer,
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-11-03 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 16:21 [PATCH v1] job.c: add missing notifier initialization Emanuele Giuseppe Esposito
2021-11-03 16:32 ` Philippe Mathieu-Daudé [this message]
2021-11-04 10:04 ` Stefan Hajnoczi
2021-11-12 18:04 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a513fe14-5fa7-ac8e-8ef8-b165055e73d5@redhat.com \
--to=philmd@redhat.com \
--cc=eesposit@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).