From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNU4S-0006mW-LL for qemu-devel@nongnu.org; Fri, 08 Dec 2017 20:36:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNU4R-0003Zc-RJ for qemu-devel@nongnu.org; Fri, 08 Dec 2017 20:36:52 -0500 References: <20171123020832.8165-1-mreitz@redhat.com> <20171123020832.8165-9-mreitz@redhat.com> <20171130031803.GL16237@lemon> <105361ec-21d2-e0dc-d480-ef3c9910dd12@redhat.com> From: John Snow Message-ID: Date: Fri, 8 Dec 2017 20:36:40 -0500 MIME-Version: 1.0 In-Reply-To: <105361ec-21d2-e0dc-d480-ef3c9910dd12@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 08/17] iotests: Skip 103 for refcount_bits=1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Fam Zheng Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org On 11/30/2017 08:23 AM, Max Reitz wrote: > On 2017-11-30 04:18, Fam Zheng wrote: >> On Thu, 11/23 03:08, Max Reitz wrote: >>> Signed-off-by: Max Reitz >>> --- >>> tests/qemu-iotests/103 | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 >>> index ecbd8ebd71..d0cfab8844 100755 >>> --- a/tests/qemu-iotests/103 >>> +++ b/tests/qemu-iotests/103 >>> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >>> _supported_fmt qcow2 >>> _supported_proto file nfs >>> _supported_os Linux >>> +# Internal snapshots are (currently) impossible with refcount_bits=1 >>> +_unsupported_imgopts 'refcount_bits=1[^0-9]' >> >> What is the "[^0-9]" part for? > > It's so you can specify refcount_bits=16, but not > refcount_bits=1,compat=0.10 or just refcount_bits=1. > > Max > Worth a comment? Reviewed-by: John Snow