Re: [PATCH 1/2] vfio: Make vfio-pci available on 64-bit host platforms only

["Cédric Le Goater" <clg@redhat.com>]

On 3/3/25 17:50, Paolo Bonzini wrote:
> 
> 
> Il lun 3 mar 2025, 16:05 Cédric Le Goater <clg@redhat.com <mailto:clg@redhat.com>> ha scritto:
> 
>     On 3/3/25 15:46, Paolo Bonzini wrote:
>      > On 3/3/25 15:30, Philippe Mathieu-Daudé wrote:
>      >>>>> I see PPC is defined in target/ppc/Kconfig so I think these mark the target not the host. Vfio-pci works with qemu-system-ppc
>      >>>
>      >>> I've seen people do this on x86_64 host
>      >>
>      >> Since this patch does:
>      >>
>      >>    LINUX && PCI && (...  X86_64 ...)
>      >>
>      >> these users won't see any change.
>      >
>      > This is wrong---clearly this patch was never tested on the 32-bit platforms where it was supposed to have an effect.
> 
>     euh it was.
> 
> 
> Uff—I should have said was *only* tested on the 32-bit platforms where it was supposed to have an effect! The problem is with the 64-bit hosts...
> 
>     With this patch, on 32-bit and 64-bit host systems :
> 
>         # build/qemu-system-i386 -device vfio-pci,?
>         # qemu-system-i386: -device vfio-pci,?: Device 'vfio-pci' not found
> 
>     Same for qemu-system-ppc and qemu-system-arm
> 
>     What I am doing wrong ?
> 
> 
> ... Where you were testing the wrong target. :) qemu-system-i386 should still support VFIO if compiled on a 64-bit host, according to the subject.

yep. I have a test case for it now ! on q35 and pc-i440fx machines.

Thanks,

C.