From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: QEMU Developers <qemu-devel@nongnu.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>,
Xu Wang <gesaint@linux.vnet.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: hw/s390x: why watchdog device diag288 is resetted twice?
Date: Thu, 26 Sep 2019 08:22:00 +0200 [thread overview]
Message-ID: <a52656b8-3b99-fb9e-f554-fbd988f62d87@redhat.com> (raw)
Hi,
hw/watchdog/wdt_diag288.c use 2 different resets:
1/ registered handler:
qemu_register_reset(diag288_reset, diag288);
2/ DeviceClass reset:
dc->reset = wdt_diag288_reset;
diag288_reset() simply calls wdt_diag288_reset():
static void wdt_diag288_reset(DeviceState *dev)
{
DIAG288State *diag288 = DIAG288(dev);
diag288->enabled = false;
timer_del(diag288->timer);
}
static void diag288_reset(void *opaque)
{
DeviceState *diag288 = opaque;
wdt_diag288_reset(diag288);
}
Why do we need this distinction?
Is this some special corner case?
Isn't this device connected to the QOM bus?
Thanks,
Phil.
next reply other threads:[~2019-09-26 6:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 6:22 Philippe Mathieu-Daudé [this message]
2019-09-26 7:17 ` hw/s390x: why watchdog device diag288 is resetted twice? David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a52656b8-3b99-fb9e-f554-fbd988f62d87@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=gesaint@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).