From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: michael.roth@amd.com, jsnow@redhat.com
Subject: Re: [PATCH] qapi: Fix parse errors for removal of null from schema language
Date: Wed, 24 Feb 2021 07:34:09 -0600 [thread overview]
Message-ID: <a53e6bb5-4745-6326-07d7-f0708a052619@redhat.com> (raw)
In-Reply-To: <20210224101442.1837475-1-armbru@redhat.com>
On 2/24/21 4:14 AM, Markus Armbruster wrote:
> Commit 9d55380b5a "qapi: Remove null from schema language" (v4.2.0)
> neglected to update two error messages. Do that now.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/parser.py | 8 ++++----
> tests/qapi-schema/leading-comma-list.err | 2 +-
> tests/qapi-schema/trailing-comma-list.err | 2 +-
> 3 files changed, 6 insertions(+), 6 deletions(-)
My first reaction was "How does our 'StrOrNull' alternate type work?
But I see that uses 'null' (that is, a string type name, just like 'str'
or 'int'), and not a literal null. At which point this makes total sense.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-02-24 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 10:14 [PATCH] qapi: Fix parse errors for removal of null from schema language Markus Armbruster
2021-02-24 13:34 ` Eric Blake [this message]
2021-02-24 21:15 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53e6bb5-4745-6326-07d7-f0708a052619@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).