From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC636C433E0 for ; Wed, 24 Feb 2021 13:56:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47CDF601FB for ; Wed, 24 Feb 2021 13:56:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47CDF601FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEuej-0001Fq-57 for qemu-devel@archiver.kernel.org; Wed, 24 Feb 2021 08:56:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57616) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEuZI-0001Yi-Ey for qemu-devel@nongnu.org; Wed, 24 Feb 2021 08:51:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEuZF-0003nf-F3 for qemu-devel@nongnu.org; Wed, 24 Feb 2021 08:51:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614174664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KA9M6Sa7pC0eaJCSxlvVAzJgcImxrAC37FeN2Zn8iVo=; b=CrfancGJkd7WPWKAgl2o/cmiWDv7OQitZwelnVXL6bprAruddYkN6xd8cG4xZnG66QAmGK kX/Lk6saJkqEgWkjDAIBYqDhEmJDgirqVlCrwsWYO/qATAKq0v+wCpmfCvmTphit6wJRZs 4n3OK/993BF07KEmnsB51stcs0dtODU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-yzzjsLezNZiqfqLiwtv6Sg-1; Wed, 24 Feb 2021 08:49:59 -0500 X-MC-Unique: yzzjsLezNZiqfqLiwtv6Sg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 79B0C18D69B8; Wed, 24 Feb 2021 13:34:10 +0000 (UTC) Received: from [10.3.113.71] (ovpn-113-71.phx2.redhat.com [10.3.113.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28AE25C224; Wed, 24 Feb 2021 13:34:10 +0000 (UTC) Subject: Re: [PATCH] qapi: Fix parse errors for removal of null from schema language To: Markus Armbruster , qemu-devel@nongnu.org References: <20210224101442.1837475-1-armbru@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: Date: Wed, 24 Feb 2021 07:34:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210224101442.1837475-1-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: michael.roth@amd.com, jsnow@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 4:14 AM, Markus Armbruster wrote: > Commit 9d55380b5a "qapi: Remove null from schema language" (v4.2.0) > neglected to update two error messages. Do that now. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/parser.py | 8 ++++---- > tests/qapi-schema/leading-comma-list.err | 2 +- > tests/qapi-schema/trailing-comma-list.err | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) My first reaction was "How does our 'StrOrNull' alternate type work? But I see that uses 'null' (that is, a string type name, just like 'str' or 'int'), and not a literal null. At which point this makes total sense. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org