From: John Snow <jsnow@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Max Reitz" <mreitz@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory
Date: Mon, 15 Feb 2021 17:27:46 -0500 [thread overview]
Message-ID: <a541cda7-47db-fc58-cd4d-e7a3aa8f0189@redhat.com> (raw)
In-Reply-To: <3830f6ae-5f92-fc0f-99dd-0783c1cd13a2@redhat.com>
On 2/15/21 1:50 PM, Wainer dos Santos Moschetta wrote:
>
> In qtest.QEMUQtestMachine.__init__(), the argument named 'test_dir'
> still make sense, right?
>
> - Wainer
It might upset pylint/mypy to rename parameters in the initializer for a
parent class. If we rename it in the base class, we should rename it in
the descendants, too.
(I say "might" because I have not yet worked out under the exact
conditions that mypy will give you LSP warnings for initializer methods.
It definitely doesn't always seem to, but I have run afoul of it enough
times that I try to avoid it as a matter of habit now.)
next prev parent reply other threads:[~2021-02-15 22:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 22:01 [PATCH 0/6] Python / Acceptance Tests: improve logging Cleber Rosa
2021-02-11 22:01 ` [PATCH 1/6] Python: close the log file kept by QEMUMachine before reading it Cleber Rosa
2021-02-15 18:30 ` Wainer dos Santos Moschetta
2021-02-16 2:34 ` Cleber Rosa
2021-02-17 19:53 ` Wainer dos Santos Moschetta
2021-02-15 22:04 ` John Snow
2021-02-15 22:19 ` Eric Blake
2021-02-16 2:35 ` Cleber Rosa
2021-02-11 22:01 ` [PATCH 2/6] Python: expose QEMUMachine's temporary directory Cleber Rosa
2021-02-11 23:35 ` Philippe Mathieu-Daudé
2021-02-12 0:11 ` Cleber Rosa
2021-02-15 22:31 ` John Snow
2021-02-15 18:50 ` Wainer dos Santos Moschetta
2021-02-15 22:27 ` John Snow [this message]
2021-02-17 19:58 ` Wainer dos Santos Moschetta
2021-02-15 22:25 ` John Snow
2021-02-11 22:01 ` [PATCH 3/6] Acceptance Tests: use the job work directory for created VMs Cleber Rosa
2021-02-15 19:04 ` Wainer dos Santos Moschetta
2021-02-15 23:13 ` John Snow
2021-02-11 22:01 ` [PATCH 4/6] Acceptance Tests: log information when creating QEMUMachine Cleber Rosa
2021-02-15 19:15 ` Wainer dos Santos Moschetta
2021-02-11 22:01 ` [PATCH 5/6] Acceptance Tests: distinguish between temp and logs dir Cleber Rosa
2021-02-15 19:30 ` Wainer dos Santos Moschetta
2021-02-11 22:01 ` [PATCH 6/6] tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log Cleber Rosa
2021-02-11 23:37 ` Philippe Mathieu-Daudé
2021-02-15 19:31 ` Wainer dos Santos Moschetta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a541cda7-47db-fc58-cd4d-e7a3aa8f0189@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).