From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dwd7i-00058s-6b for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:49:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dwd7f-0004wC-54 for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:49:14 -0400 Received: from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235]:51842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dwd7e-0004w0-Tv for qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:49:11 -0400 Received: by mail-pg0-x235.google.com with SMTP id k193so4914836pgc.8 for ; Mon, 25 Sep 2017 16:49:10 -0700 (PDT) References: <20170918160012.4317-1-david@redhat.com> <20170918160012.4317-17-david@redhat.com> From: Richard Henderson Message-ID: Date: Mon, 25 Sep 2017 16:49:06 -0700 MIME-Version: 1.0 In-Reply-To: <20170918160012.4317-17-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 16/27] s390x/kvm: factor out SIGP code into sigp.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: thuth@redhat.com, cohuck@redhat.com, borntraeger@de.ibm.com, Alexander Graf , Igor Mammedov , Aurelien Jarno , Matthew Rosato , =?UTF-8?Q?Alex_Benn=c3=a9e?= On 09/18/2017 09:00 AM, David Hildenbrand wrote: > We want to use the same code base for TCG, so let's cleanly factor it > out. > > The sigp mutex is currently not really needed, as everything is > protected by the iothread mutex. But this could change later, so leave > it in place and initialize it properly from common code. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 3 + > target/s390x/Makefile.objs | 1 + > target/s390x/cpu.c | 8 - > target/s390x/cpu.h | 6 +- > target/s390x/internal.h | 4 + > target/s390x/kvm-stub.c | 5 - > target/s390x/kvm.c | 349 +----------------------------------------- > target/s390x/kvm_s390x.h | 1 - > target/s390x/sigp.c | 366 +++++++++++++++++++++++++++++++++++++++++++++ > target/s390x/trace-events | 4 +- > 10 files changed, 388 insertions(+), 359 deletions(-) > create mode 100644 target/s390x/sigp.c Reviewed-by: Richard Henderson r~