From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bteDt-00083v-MC for qemu-devel@nongnu.org; Mon, 10 Oct 2016 13:18:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bteDp-0006wL-FH for qemu-devel@nongnu.org; Mon, 10 Oct 2016 13:18:44 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bteDp-0006vt-6T for qemu-devel@nongnu.org; Mon, 10 Oct 2016 13:18:41 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9AHIb8V059113 for ; Mon, 10 Oct 2016 13:18:40 -0400 Received: from e06smtp09.uk.ibm.com (e06smtp09.uk.ibm.com [195.75.94.105]) by mx0a-001b2d01.pphosted.com with ESMTP id 260e0r380j-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 10 Oct 2016 13:18:39 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Oct 2016 18:18:36 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 11D8D17D8024 for ; Mon, 10 Oct 2016 18:20:41 +0100 (BST) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u9AHIXLr18350228 for ; Mon, 10 Oct 2016 17:18:33 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u9AHIWo7018733 for ; Mon, 10 Oct 2016 13:18:33 -0400 References: <133a4c1d-d029-0bc2-d538-4e5c8e3dac1b@redhat.com> <20161010154625.14881-1-alex.bennee@linaro.org> <6286d817-fbe6-afdb-2352-e5cf0b54d859@redhat.com> From: Christian Borntraeger Date: Mon, 10 Oct 2016 19:18:32 +0200 MIME-Version: 1.0 In-Reply-To: <6286d817-fbe6-afdb-2352-e5cf0b54d859@redhat.com> Content-Type: text/plain; charset=utf-8 Message-Id: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] kvm-all: don't use stale dbg_data->cpu List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , imbrenda@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, "open list:Overall" On 10/10/2016 06:39 PM, Paolo Bonzini wrote: >=20 >=20 > On 10/10/2016 17:46, Alex Benn=C3=A9e wrote: >> The changes to run_on_cpu and friends mean that all helpers are passed >> the CPUState of vCPU they are running on. The conversion missed the >> field in commit e0eeb4a21a3ca4b296220ce4449d8acef9de9049 which >> introduced bugs. >> >> Reported-by: Claudio Imbrenda >> Signed-off-by: Alex Benn=C3=A9e >> --- >> kvm-all.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index efb5fe3..3dcce16 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -2215,15 +2215,14 @@ int kvm_sw_breakpoints_active(CPUState *cpu) >> =20 >> struct kvm_set_guest_debug_data { >> struct kvm_guest_debug dbg; >> - CPUState *cpu; >> int err; >> }; >> =20 >> -static void kvm_invoke_set_guest_debug(CPUState *unused_cpu, void *da= ta) >> +static void kvm_invoke_set_guest_debug(CPUState *cpu, void *data) >> { >> struct kvm_set_guest_debug_data *dbg_data =3D data; >> =20 >> - dbg_data->err =3D kvm_vcpu_ioctl(dbg_data->cpu, KVM_SET_GUEST_DEB= UG, >> + dbg_data->err =3D kvm_vcpu_ioctl(cpu, KVM_SET_GUEST_DEBUG, >> &dbg_data->dbg); >> } >> =20 >> >=20 > Queued, thanks - or if Christian wants to send a pull request himself, > he can go ahead. Lets wait for Claudio to verify and then it can go via your tree. PS: Can you also have a look at Claudios 2nd patch?