From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Peter Krempa <pkrempa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v5 3/3] iotests: Test node/bitmap aliases during migration
Date: Thu, 20 Aug 2020 19:39:58 -0500 [thread overview]
Message-ID: <a556bce6-e9ed-bb3d-b792-d2606083fc90@redhat.com> (raw)
In-Reply-To: <20200820150725.68687-4-mreitz@redhat.com>
On 8/20/20 10:07 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/300 | 595 +++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/300.out | 5 +
> tests/qemu-iotests/group | 1 +
> 3 files changed, 601 insertions(+)
> create mode 100755 tests/qemu-iotests/300
> create mode 100644 tests/qemu-iotests/300.out
>
The changes in patch 1 helped; the test completes for me in 11 s.
Minimal differences to v4, and the switch to discard is nice.
Tested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
I've gone ahead and queued this on my bitmaps tree with testing on top
of Paolo's meson conversion; I'm prepared to send a pull request once
that lands.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-08-21 0:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 15:07 [PATCH v5 0/3] migration: Add block-bitmap-mapping parameter Max Reitz
2020-08-20 15:07 ` [PATCH v5 1/3] " Max Reitz
2020-08-20 15:56 ` Vladimir Sementsov-Ogievskiy
2020-08-21 0:37 ` Eric Blake
2020-08-20 15:07 ` [PATCH v5 2/3] iotests.py: Let wait_migration() return on failure Max Reitz
2020-08-20 15:07 ` [PATCH v5 3/3] iotests: Test node/bitmap aliases during migration Max Reitz
2020-08-20 16:01 ` Vladimir Sementsov-Ogievskiy
2020-08-21 0:39 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a556bce6-e9ed-bb3d-b792-d2606083fc90@redhat.com \
--to=eblake@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).