qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>,
	David Hildenbrand <david@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Subject: [PATCH][PING] linux-user/elfload: Fix /proc/cpuinfo features: on s390x
Date: Fri, 14 Jul 2023 14:16:22 +0200	[thread overview]
Message-ID: <a55d41f884e6ff50872d389fa1a7c3dcf61afcc1.camel@linux.ibm.com> (raw)
In-Reply-To: <f359dae7-e0a3-42cf-c2cd-fff7f9c3a607@linaro.org>

On Wed, 2023-06-28 at 09:49 +0200, Richard Henderson wrote:
> On 6/27/23 17:13, Ilya Leoshkevich wrote:
> > elf_hwcap_str() takes a bit number, but compares it for equality
> > with
> > the HWCAP_S390_* masks. This causes /proc/cpuinfo to display
> > incorrect
> > hwcaps.
> > 
> > Fix by introducing the HWCAP_S390_NR_* constants and using them in
> > elf_hwcap_str() instead of the HWCAP_S390_*. While at it, add the
> > missing nnpa, pcimio and sie hwcaps from the latest kernel.
> > 
> > Output before:
> > 
> >         features        : esan3 zarch stfle msa
> > 
> > Output after:
> > 
> >         features        : esan3 zarch stfle msa ldisp eimm etf3eh
> > highgprs vx vxe
> > 
> > Fixes: e19807bee357 ("linux-user/elfload: Introduce elf_hwcap_str()
> > on s390x")
> > Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> > ---
> >   include/elf.h        | 66 +++++++++++++++++++++++++++++++--------
> > -----
> >   linux-user/elfload.c | 41 ++++++++++++++-------------
> >   2 files changed, 69 insertions(+), 38 deletions(-)
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> 
> r~

Hi,

I noticed that while the other s390x fixes were picked up and are in
master, this one wasn't. Is there anything I need to improve here?

Best regards,
Ilya


  reply	other threads:[~2023-07-14 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 15:13 [PATCH] linux-user/elfload: Fix /proc/cpuinfo features: on s390x Ilya Leoshkevich
2023-06-28  7:49 ` Richard Henderson
2023-07-14 12:16   ` Ilya Leoshkevich [this message]
2023-07-17  7:44     ` [PATCH][PING] " Richard Henderson
2023-07-17 12:31       ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a55d41f884e6ff50872d389fa1a7c3dcf61afcc1.camel@linux.ibm.com \
    --to=iii@linux.ibm.com \
    --cc=david@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).