qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>,
	Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
	qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, vsementsov@virtuozzo.com,
	rkagan@virtuozzo.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect
Date: Mon, 15 Jul 2019 20:27:24 +0200	[thread overview]
Message-ID: <a55d4518-734e-9dd1-296f-473600eacbf7@redhat.com> (raw)
In-Reply-To: <b270d0cc-2a28-8a60-ccac-45ac4de89f02@redhat.com>

On 15/07/19 19:23, Max Reitz wrote:
> On 12.07.19 21:17, Andrey Shinkevich wrote:
>> When tcp_chr_disconnect() is called, other thread may be still writing
>> to the channel. This patch protects only read operations that initiate
>> the disconnection.
>>
>> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
>> ---
> 
> Have you looked at
> https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg06174.html
> already?  From a glance, it looks like that series supersedes this one.
> 
> (No, I don’t know why the other series is delayed.

Because it broke some testcases in tests/vhost-user-test.  They are
disabled by default, because AFAIR they broke on some CI environment,
but they are supposed to work.

Paolo

> I keep reminding
> Paolo of it.)
> 
> Max
> 



  reply	other threads:[~2019-07-15 18:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-12 19:17 [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect Andrey Shinkevich
2019-07-15 17:23 ` Max Reitz
2019-07-15 18:27   ` Paolo Bonzini [this message]
2019-07-16  7:47     ` Max Reitz
2019-07-16 13:08     ` Andrey Shinkevich
2019-07-16 14:24       ` Paolo Bonzini
2019-07-17  8:44         ` Andrey Shinkevich
2019-07-17  8:28     ` Andrey Shinkevich
2019-07-16 13:02   ` Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a55d4518-734e-9dd1-296f-473600eacbf7@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=andrey.shinkevich@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).