From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59759) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKgxw-0007vn-T4 for qemu-devel@nongnu.org; Thu, 08 Nov 2018 04:51:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKgxs-0001rn-Dr for qemu-devel@nongnu.org; Thu, 08 Nov 2018 04:51:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52728) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gKgxr-0001eo-TF for qemu-devel@nongnu.org; Thu, 08 Nov 2018 04:51:04 -0500 References: <20181102034649.43559-1-liran.alon@oracle.com> <1C803EF0-9E1B-4E1B-A4DD-4BE788A7A1FF@oracle.com> From: Paolo Bonzini Message-ID: Date: Thu, 8 Nov 2018 10:50:46 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU PATCH v2 0/2]: KVM: i386: Add support for save and restore nested state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jim Mattson , Liran Alon Cc: "Dr. David Alan Gilbert" , Eduardo Habkost , kvm list , mtosatti@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org On 08/11/2018 01:45, Jim Mattson wrote: > I have no attachments to the current design. I had used a data[] blob, > because I didn't think userspace would have any need to know what was > in there. However, I am now seeing the error of my ways. For example, > the userspace instruction emulator needs to know the contents of the > vmcs12 to emulate instructions when in guest mode. Yeah, we're probably going to have to document the KVM vmcs12 structure, possibly moving it to uapi. But that's a different thing from save/restore state, which can use the 4K or 8K data[] blob. Paolo