qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode
Date: Tue, 20 Nov 2018 12:22:39 -0600	[thread overview]
Message-ID: <a56dbf66-14f1-5a57-0f0f-28877072d176@redhat.com> (raw)
In-Reply-To: <20181120175333.GB25047@redhat.com>

On 11/20/18 11:53 AM, Daniel P. Berrangé wrote:

>>>> +echo
>>>> +echo "== preparing TLS creds =="
>>>> +
>>>> +tls_x509_create_root_ca "ca1"
>>>> +tls_x509_create_root_ca "ca2"
>>>> +tls_x509_create_server "ca1" "server1"
>>>> +tls_x509_create_client "ca1" "client1"
>>>> +tls_x509_create_client "ca2" "client2"
>>>
>>> Looks like we can't blindly assume that certtool exists. This test case
>>> fails for me, starting with the following diff:
>>
>> Looks like we'll need a followup patch to skip the test if certtool is not
>> found. (I already did the same in common.nbd if 'ss' was not found; so it
>> should be easy to copy...)
> 
> FWIW certtool is part of gnutls-utils and is available on every platform
> that QEMU officially supports as a build target.

Ported to the build target != installed on the build machine. The 
failure is happening on machines that do not have all the build 
prerequisites (since it should still be possible to configure qemu to 
build without TLS, right?)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

  reply	other threads:[~2018-11-20 18:27 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 15:53 [Qemu-devel] [PATCH 0/6] Misc fixes to NBD Daniel P. Berrangé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 1/6 for-3.1] nbd: fix whitespace in server error message Daniel P. Berrangé
2018-11-16 16:01   ` Eric Blake
2018-11-19 16:29     ` Philippe Mathieu-Daudé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 2/6 for-3.1] nbd: stop waiting for a NBD response with NBD_CMD_DISC Daniel P. Berrangé
2018-11-16 16:08   ` Eric Blake
2018-11-18  2:19   ` Eric Blake
2018-11-19 10:23     ` Daniel P. Berrangé
2018-11-19 14:24       ` Eric Blake
2018-11-19 13:47     ` Daniel P. Berrangé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file Daniel P. Berrangé
2018-11-16 16:11   ` Eric Blake
2018-11-16 21:41   ` Eric Blake
2018-11-16 21:43     ` Eric Blake
2018-11-19 10:24       ` Daniel P. Berrangé
2018-11-18  3:01   ` Eric Blake
2018-11-19 10:24     ` Daniel P. Berrangé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 4/6] tests: check if qemu-nbd is still alive before waiting Daniel P. Berrangé
2018-11-16 16:24   ` Eric Blake
2018-11-19 10:26     ` Daniel P. Berrangé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 5/6] tests: add iotests helpers for dealing with TLS certificates Daniel P. Berrangé
2018-11-16 16:39   ` Eric Blake
2018-11-19 10:27     ` Daniel P. Berrangé
2018-11-19 11:04       ` Max Reitz
2018-11-19 14:27         ` Eric Blake
2018-11-19 14:32           ` Daniel P. Berrangé
2018-11-16 15:53 ` [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode Daniel P. Berrangé
2018-11-16 17:20   ` Eric Blake
2018-11-17 21:31     ` Eric Blake
2018-11-19 10:37       ` Daniel P. Berrangé
2018-11-19 17:00         ` Eric Blake
2018-11-20  9:40           ` Daniel P. Berrangé
2018-11-19 10:36     ` Daniel P. Berrangé
2018-11-17 20:49   ` Eric Blake
2018-11-17 22:31     ` Eric Blake
2018-11-17 22:32     ` [Qemu-devel] [PATCH 1.5/6] nbd/server: Ignore write errors when replying to NBD_OPT_ABORT Eric Blake
2018-11-19 10:39       ` Daniel P. Berrangé
2018-11-19 10:39     ` [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode Daniel P. Berrangé
2018-11-18  2:24   ` [Qemu-devel] [PATCH 7/6] iotests: Also test I/O over NBD TLS Eric Blake
2018-11-19 10:40     ` Daniel P. Berrangé
2018-11-19 17:11       ` Eric Blake
2018-11-19 17:04   ` [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode Eric Blake
2018-11-20 17:27   ` Kevin Wolf
2018-11-20 17:45     ` Eric Blake
2018-11-20 17:53       ` Daniel P. Berrangé
2018-11-20 18:22         ` Eric Blake [this message]
2018-11-20 21:56           ` Kevin Wolf
2018-11-21  9:30           ` Daniel P. Berrangé
2018-11-18  2:39 ` [Qemu-devel] [PATCH 0/6] Misc fixes to NBD Eric Blake
2018-11-27 15:42 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a56dbf66-14f1-5a57-0f0f-28877072d176@redhat.com \
    --to=eblake@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).