qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Sergio Lopez <slp@redhat.com>,
	qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, mst@redhat.com, kraxel@redhat.com,
	imammedo@redhat.com, rth@twiddle.net, lersek@redhat.com,
	sgarzare@redhat.com
Subject: Re: [PATCH v9 14/15] hw/i386: Introduce the microvm machine type
Date: Wed, 16 Oct 2019 11:26:39 +0200	[thread overview]
Message-ID: <a5863b05-4021-df51-d84f-1bb070fa6137@redhat.com> (raw)
In-Reply-To: <6276a8e7-2928-6e33-64a1-3ae01a30a718@redhat.com>

On 10/16/19 9:46 AM, Paolo Bonzini wrote:
> 
>> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
>> index c5c9d4900e..d399dcba52 100644
>> --- a/hw/i386/Kconfig
>> +++ b/hw/i386/Kconfig
>> @@ -92,6 +92,10 @@ config Q35
>>       select SMBIOS
>>       select FW_CFG_DMA
>>   
>> +config MICROVM
>> +    bool
> 
> Missing:
> 
>      select ISA_BUS
>      select APIC
>      select IOAPIC
>      select I8259
>      select MC146818RTC

maybe 'select SERIAL_ISA' too?

> No need to post v10 just for this.
> 
> Paolo
> 
> 
>> +    select VIRTIO_MMIO
>> +
>>   config VTD
>>       bool
>>   
>> diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
>> index 7ed80a4853..0d195b5210 100644
>> --- a/hw/i386/Makefile.objs
>> +++ b/hw/i386/Makefile.objs
>> @@ -4,6 +4,7 @@ obj-y += x86.o
>>   obj-y += pc.o
>>   obj-$(CONFIG_I440FX) += pc_piix.o
>>   obj-$(CONFIG_Q35) += pc_q35.o
>> +obj-$(CONFIG_MICROVM) += microvm.o
>>   obj-y += fw_cfg.o pc_sysfw.o
>>   obj-y += x86-iommu.o
>>   obj-$(CONFIG_VTD) += intel_iommu.o
>>
> 


  reply	other threads:[~2019-10-16  9:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 11:23 [PATCH v9 00/15] Introduce the microvm machine type Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 01/15] hw/virtio: Factorize virtio-mmio headers Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 02/15] hw/i386/pc: rename functions shared with non-PC machines Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 03/15] hw/i386/pc: fix code style issues on functions that will be moved out Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 04/15] hw/i386/pc: replace use of strtol with qemu_strtol in x86_load_linux() Sergio Lopez
2019-10-15 11:36   ` Philippe Mathieu-Daudé
2019-10-16 20:40     ` Markus Armbruster
2019-10-17  6:43       ` Sergio Lopez
2019-10-18  5:05         ` Markus Armbruster
2019-10-15 11:23 ` [PATCH v9 05/15] hw/i386/pc: avoid an assignment in if condition " Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 06/15] hw/i386/pc: remove commented out code from x86_load_linux() Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 07/15] hw/i386/pc: move shared x86 functions to x86.c and export them Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 08/15] hw/i386: split PCMachineState deriving X86MachineState from it Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 09/15] hw/i386: make x86.c independent from PCMachineState Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 10/15] fw_cfg: add "modify" functions for all types Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 11/15] hw/intc/apic: reject pic ints if isa_pic == NULL Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 12/15] roms: add microvm-bios (qboot) as binary and git submodule Sergio Lopez
2019-10-15 11:23 ` [PATCH v9 13/15] docs/microvm.rst: document the new microvm machine type Sergio Lopez
2019-10-15 11:50   ` Greg Kurz
2019-10-15 11:23 ` [PATCH v9 14/15] hw/i386: Introduce the " Sergio Lopez
2019-10-16  7:46   ` Paolo Bonzini
2019-10-16  9:26     ` Philippe Mathieu-Daudé [this message]
2019-10-16  9:29       ` Paolo Bonzini
2019-12-24  0:09         ` Philippe Mathieu-Daudé
2020-01-07 13:35           ` Paolo Bonzini
2020-01-07 13:56             ` Philippe Mathieu-Daudé
2019-10-15 11:23 ` [PATCH v9 15/15] MAINTAINERS: add microvm related files Sergio Lopez
2019-10-15 11:39   ` Philippe Mathieu-Daudé
2019-10-15 11:45   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5863b05-4021-df51-d84f-1bb070fa6137@redhat.com \
    --to=philmd@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sgarzare@redhat.com \
    --cc=slp@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).