From: Amit Shah <amit.shah@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>,
qemu list <qemu-devel@nongnu.org>,
peterx@redhat.com, "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Amit Shah <amit.shah@redhat.com>,
den@openvz.org
Subject: [Qemu-devel] [PULL 3/4] postcopy: listen thread is never joined
Date: Fri, 11 Mar 2016 18:02:13 +0530 [thread overview]
Message-ID: <a587a3fe6cadd3ce1d53235ecd759f0990132bf3.1457699452.git.amit.shah@redhat.com> (raw)
In-Reply-To: <cover.1457699452.git.amit.shah@redhat.com>
In-Reply-To: <cover.1457699452.git.amit.shah@redhat.com>
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
We don't join the listen thread, it does its own cleanup.
Mark as detached not joinable.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1457690016-9070-2-git-send-email-dgilbert@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 384e872..0a33c22 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1494,7 +1494,7 @@ static int loadvm_postcopy_handle_listen(MigrationIncomingState *mis)
qemu_sem_init(&mis->listen_thread_sem, 0);
qemu_thread_create(&mis->listen_thread, "postcopy/listen",
postcopy_ram_listen_thread, mis->from_src_file,
- QEMU_THREAD_JOINABLE);
+ QEMU_THREAD_DETACHED);
qemu_sem_wait(&mis->listen_thread_sem);
qemu_sem_destroy(&mis->listen_thread_sem);
--
2.5.0
next prev parent reply other threads:[~2016-03-11 12:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 12:32 [Qemu-devel] [PULL 0/4] migration fixes Amit Shah
2016-03-11 12:32 ` [Qemu-devel] [PULL 1/4] migration: fix warning for source_return_path_thread Amit Shah
2016-03-11 12:32 ` [Qemu-devel] [PULL 2/4] migration: fix use-after-free in loadvm_postcopy_handle_run_bh Amit Shah
2016-03-11 12:32 ` Amit Shah [this message]
2016-03-11 12:32 ` [Qemu-devel] [PULL 4/4] postcopy: Remove the x- Amit Shah
2016-03-14 14:44 ` [Qemu-devel] [PULL 0/4] migration fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a587a3fe6cadd3ce1d53235ecd759f0990132bf3.1457699452.git.amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).