From: Richard Henderson <rth@twiddle.net>
To: Sergey Sorokin <afarallax@yandex.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Alexander Graf <agraf@suse.de>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
Claudio Fontana <claudio.fontana@huawei.com>,
Vassili Karpov <av1474@comtv.ru>
Subject: Re: [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure
Date: Thu, 23 Jun 2016 12:06:35 -0700 [thread overview]
Message-ID: <a58d7cf7-b586-bf4e-1336-b31dc58d4580@twiddle.net> (raw)
In-Reply-To: <804691466706062@web16g.yandex.ru>
On 06/23/2016 11:21 AM, Sergey Sorokin wrote:
> Yes, I thought about it. tcg_canonicalize_memop() is good place too.
> But do you think that get_alignment_bits() is not good enough?
I think the earlier a target-* translator problem is diagnosed the better.
Leaving things in get_alignment_bits is ok, so long as we then invoke
get_alignment bits in tcg_canonicalize_memop. Perhaps
static inline TCGMemOp tcg_canonicalize_memop(TCGMemOp op, bool is64, bool st)
{
/* Trigger the asserts within sooner rather than later. */
(void)get_alignment_bits(op);
...
}
r~
prev parent reply other threads:[~2016-06-23 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 12:37 [Qemu-devel] [PATCH v2] Improve the alignment check infrastructure Sergey Sorokin
2016-06-22 15:49 ` Richard Henderson
2016-06-22 16:30 ` Sergey Sorokin
2016-06-22 17:12 ` Richard Henderson
2016-06-23 10:03 ` Sergey Sorokin
2016-06-23 14:05 ` Richard Henderson
2016-06-23 14:13 ` Sergey Sorokin
2016-06-23 14:45 ` Sergey Sorokin
2016-06-23 16:12 ` Richard Henderson
2016-06-23 18:21 ` Sergey Sorokin
2016-06-23 19:06 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a58d7cf7-b586-bf4e-1336-b31dc58d4580@twiddle.net \
--to=rth@twiddle.net \
--cc=afarallax@yandex.ru \
--cc=agraf@suse.de \
--cc=av1474@comtv.ru \
--cc=claudio.fontana@huawei.com \
--cc=crosthwaite.peter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).