From: Richard Henderson <richard.henderson@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets
Date: Tue, 10 Apr 2018 13:20:22 +1000 [thread overview]
Message-ID: <a59566f6-2423-cd50-9ff4-cf8ec227dbde@linaro.org> (raw)
In-Reply-To: <20180410021745.32378-2-jcmvbkbc@gmail.com>
On 04/10/2018 12:17 PM, Max Filippov wrote:
> + uint64_t off = tlow |
> + ((unsigned long long)thigh << TARGET_LONG_BITS / 2) <<
There's a second instance of long long here; needs uint64_t.
r~
next prev parent reply other threads:[~2018-04-10 3:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 2:17 [Qemu-devel] [PULL 0/1] linux-user: fix file offset for preadv/pwritev Max Filippov
2018-04-10 2:17 ` [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets Max Filippov
2018-04-10 3:20 ` Richard Henderson [this message]
2018-04-10 3:29 ` Max Filippov
2018-04-10 4:05 ` Richard Henderson
2018-04-10 11:48 ` [Qemu-devel] [PULL 0/1] linux-user: fix file offset for preadv/pwritev Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59566f6-2423-cd50-9ff4-cf8ec227dbde@linaro.org \
--to=richard.henderson@linaro.org \
--cc=jcmvbkbc@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).