From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5jpg-0003fM-B6 for qemu-devel@nongnu.org; Mon, 09 Apr 2018 23:20:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5jpe-0001kR-KT for qemu-devel@nongnu.org; Mon, 09 Apr 2018 23:20:31 -0400 Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:40085) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f5jpe-0001jv-DF for qemu-devel@nongnu.org; Mon, 09 Apr 2018 23:20:30 -0400 Received: by mail-pf0-x22a.google.com with SMTP id y66so7070333pfi.7 for ; Mon, 09 Apr 2018 20:20:30 -0700 (PDT) References: <20180410021745.32378-1-jcmvbkbc@gmail.com> <20180410021745.32378-2-jcmvbkbc@gmail.com> From: Richard Henderson Message-ID: Date: Tue, 10 Apr 2018 13:20:22 +1000 MIME-Version: 1.0 In-Reply-To: <20180410021745.32378-2-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Filippov , qemu-devel@nongnu.org Cc: Peter Maydell , Riku Voipio , Laurent Vivier On 04/10/2018 12:17 PM, Max Filippov wrote: > + uint64_t off = tlow | > + ((unsigned long long)thigh << TARGET_LONG_BITS / 2) << There's a second instance of long long here; needs uint64_t. r~