qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH 09/10] fpu: Don't compile-time disable hardfloat for PPC targets
Date: Mon, 17 Feb 2025 11:27:44 -0800	[thread overview]
Message-ID: <a59d809b-da1c-4a9d-ac19-7eae75f918af@linaro.org> (raw)
In-Reply-To: <20250217125055.160887-10-peter.maydell@linaro.org>

On 2/17/25 04:50, Peter Maydell wrote:
> We happen to know that for the PPC target the FP status flags (and in
> particular float_flag_inexact) will always be cleared before a
> floating point operation, and so can_use_fpu() will always return
> false.  So we speed things up a little by forcing QEMU_NO_HARDFLOAT
> to true on that target.
> 
> We would like to build softfloat once for all targets; that means
> removing target-specific ifdefs.  Remove the check for TARGET_PPC;
> this won't change behaviour because can_use_fpu() will see that
> float_flag_inexact is clear and take the softfloat path anyway.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   fpu/softfloat.c | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

This makes ppc no different from the many other targets which clear out softfloat 
exception flags after every operation.


r~


  reply	other threads:[~2025-02-17 19:28 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 12:50 [PATCH 00/10] fpu: Remove remaining target ifdefs and build only once Peter Maydell
2025-02-17 12:50 ` [PATCH 01/10] fpu: Make targets specify floatx80 default Inf at runtime Peter Maydell
2025-02-17 18:09   ` Richard Henderson
2025-02-21 14:42   ` Philippe Mathieu-Daudé
2025-02-21 15:16     ` Peter Maydell
2025-02-17 12:50 ` [PATCH 02/10] target/m68k: Avoid using floatx80_infinity global const Peter Maydell
2025-02-17 18:10   ` Richard Henderson
2025-02-21 13:51   ` Philippe Mathieu-Daudé
2025-02-17 12:50 ` [PATCH 03/10] target/i386: " Peter Maydell
2025-02-17 18:10   ` Richard Henderson
2025-02-21 13:40   ` Philippe Mathieu-Daudé
2025-02-17 12:50 ` [PATCH 04/10] fpu: Make targets specify whether floatx80 Inf can have Int bit clear Peter Maydell
2025-02-17 18:13   ` Richard Henderson
2025-02-21 13:12   ` Philippe Mathieu-Daudé
2025-02-17 12:50 ` [PATCH 05/10] fpu: Make floatx80 invalid encoding settable at runtime Peter Maydell
2025-02-17 18:45   ` Richard Henderson
2025-02-21 13:14   ` Philippe Mathieu-Daudé
2025-02-17 12:50 ` [PATCH 06/10] fpu: Move m68k_denormal fmt flag into floatx80_behaviour Peter Maydell
2025-02-17 19:14   ` Richard Henderson
2025-02-20 17:12     ` Peter Maydell
2025-02-20 18:39       ` Richard Henderson
2025-02-20 18:54         ` Peter Maydell
2025-02-21 14:14           ` Philippe Mathieu-Daudé
2025-02-21 22:24           ` Richard Henderson
2025-02-17 12:50 ` [PATCH 07/10] fpu: Always decide no_signaling_nans() at runtime Peter Maydell
2025-02-17 13:13   ` Philippe Mathieu-Daudé
2025-02-17 19:25   ` Richard Henderson
2025-02-17 12:50 ` [PATCH 08/10] fpu: Always decide snan_bit_is_one() " Peter Maydell
2025-02-17 13:15   ` Philippe Mathieu-Daudé
2025-02-17 19:26   ` Richard Henderson
2025-02-17 12:50 ` [PATCH 09/10] fpu: Don't compile-time disable hardfloat for PPC targets Peter Maydell
2025-02-17 19:27   ` Richard Henderson [this message]
2025-02-17 12:50 ` [PATCH 10/10] fpu: Build only once Peter Maydell
2025-02-17 19:28   ` Richard Henderson
2025-02-20  8:48 ` [PATCH 00/10] fpu: Remove remaining target ifdefs and build " Philippe Mathieu-Daudé
2025-02-20  9:00   ` Philippe Mathieu-Daudé
2025-02-21 10:48   ` Philippe Mathieu-Daudé
2025-02-21 13:05 ` Philippe Mathieu-Daudé
2025-02-21 13:28   ` Peter Maydell
2025-02-21 13:48     ` Philippe Mathieu-Daudé
2025-02-21 14:41 ` Philippe Mathieu-Daudé
2025-02-21 15:19   ` Peter Maydell
2025-02-21 16:21     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a59d809b-da1c-4a9d-ac19-7eae75f918af@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=eduardo@habkost.net \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).