[PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[Keoseong Park]

In ufs_write_attr_value(), the value parameter is handled in the CPU's
endian format but provided in big-endian format by the caller. Thus, it
is converted to the CPU's endian format. The related test code is also
fixed to reflect this change.

Fixes: 7c85332a2b3e ("hw/ufs: minor bug fixes related to ufs-test")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
 hw/ufs/ufs.c           | 2 +-
 tests/qtest/ufs-test.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
index 8d26d13791..428fe927ad 100644
--- a/hw/ufs/ufs.c
+++ b/hw/ufs/ufs.c
@@ -1164,7 +1164,7 @@ static QueryRespCode ufs_exec_query_attr(UfsRequest *req, int op)
         value = ufs_read_attr_value(u, idn);
         ret = UFS_QUERY_RESULT_SUCCESS;
     } else {
-        value = req->req_upiu.qr.value;
+        value = be32_to_cpu(req->req_upiu.qr.value);
         ret = ufs_write_attr_value(u, idn, value);
     }
     req->rsp_upiu.qr.value = cpu_to_be32(value);
diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
index 60199abbee..1f860b41c0 100644
--- a/tests/qtest/ufs-test.c
+++ b/tests/qtest/ufs-test.c
@@ -145,7 +145,7 @@ static void ufs_send_query(QUfs *ufs, uint8_t slot, uint8_t query_function,
     req_upiu.qr.idn = idn;
     req_upiu.qr.index = index;
     req_upiu.qr.selector = selector;
-    req_upiu.qr.value = attr_value;
+    req_upiu.qr.value = cpu_to_be32(attr_value);
     req_upiu.qr.length = UFS_QUERY_DESC_MAX_SIZE;
     qtest_memwrite(ufs->dev.bus->qts, req_upiu_addr, &req_upiu,
                    sizeof(req_upiu));
-- 
2.25.1

Re: [PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[Jeuk Kim]

On 1/7/2025 5:43 PM, Keoseong Park wrote:
> In ufs_write_attr_value(), the value parameter is handled in the CPU's
> endian format but provided in big-endian format by the caller. Thus, it
> is converted to the CPU's endian format. The related test code is also
> fixed to reflect this change.
>
> Fixes: 7c85332a2b3e ("hw/ufs: minor bug fixes related to ufs-test")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
> ---
>   hw/ufs/ufs.c           | 2 +-
>   tests/qtest/ufs-test.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c
> index 8d26d13791..428fe927ad 100644
> --- a/hw/ufs/ufs.c
> +++ b/hw/ufs/ufs.c
> @@ -1164,7 +1164,7 @@ static QueryRespCode ufs_exec_query_attr(UfsRequest *req, int op)
>           value = ufs_read_attr_value(u, idn);
>           ret = UFS_QUERY_RESULT_SUCCESS;
>       } else {
> -        value = req->req_upiu.qr.value;
> +        value = be32_to_cpu(req->req_upiu.qr.value);
>           ret = ufs_write_attr_value(u, idn, value);
>       }
>       req->rsp_upiu.qr.value = cpu_to_be32(value);
> diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
> index 60199abbee..1f860b41c0 100644
> --- a/tests/qtest/ufs-test.c
> +++ b/tests/qtest/ufs-test.c
> @@ -145,7 +145,7 @@ static void ufs_send_query(QUfs *ufs, uint8_t slot, uint8_t query_function,
>       req_upiu.qr.idn = idn;
>       req_upiu.qr.index = index;
>       req_upiu.qr.selector = selector;
> -    req_upiu.qr.value = attr_value;
> +    req_upiu.qr.value = cpu_to_be32(attr_value);
>       req_upiu.qr.length = UFS_QUERY_DESC_MAX_SIZE;
>       qtest_memwrite(ufs->dev.bus->qts, req_upiu_addr, &req_upiu,
>                      sizeof(req_upiu));


Thank you for your contribution.

Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>

Re: [PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[Philippe Mathieu-Daudé]

On 7/1/25 09:43, Keoseong Park wrote:
> In ufs_write_attr_value(), the value parameter is handled in the CPU's
> endian format but provided in big-endian format by the caller. Thus, it
> is converted to the CPU's endian format. The related test code is also
> fixed to reflect this change.
> 
> Fixes: 7c85332a2b3e ("hw/ufs: minor bug fixes related to ufs-test")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Keoseong Park <keosung.park@samsung.com>
> ---
>   hw/ufs/ufs.c           | 2 +-
>   tests/qtest/ufs-test.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
Patch queued, thanks.

Re: [PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[Michael Tokarev]

07.01.2025 11:43, Keoseong Park wrote:
> In ufs_write_attr_value(), the value parameter is handled in the CPU's
> endian format but provided in big-endian format by the caller. Thus, it
> is converted to the CPU's endian format. The related test code is also
> fixed to reflect this change.
> 
> Fixes: 7c85332a2b3e ("hw/ufs: minor bug fixes related to ufs-test")

This seems to be a qemu-stable material.  I'm picking it up for 9.2,
please let me know if I should not.

Thanks,

/mjt

Re: [PATCH v2] hw/ufs: Adjust value to match CPU's endian format

[Philippe Mathieu-Daudé]

On 15/1/25 13:53, Michael Tokarev wrote:
> 07.01.2025 11:43, Keoseong Park wrote:
>> In ufs_write_attr_value(), the value parameter is handled in the CPU's
>> endian format but provided in big-endian format by the caller. Thus, it
>> is converted to the CPU's endian format. The related test code is also
>> fixed to reflect this change.
>>
>> Fixes: 7c85332a2b3e ("hw/ufs: minor bug fixes related to ufs-test")
> 
> This seems to be a qemu-stable material.  I'm picking it up for 9.2,
> please let me know if I should not.

Correct, sorry for missing adding a Cc:stable tag here.