Re: [PATCH] linux-user: fix layout of struct target_msq_id_ds

[Richard Henderson <richard.henderson@linaro.org>]

On 10/9/25 08:42, Richard Henderson wrote:
> On 10/9/25 05:56, Andreas Schwab wrote:
>> The msg_lspid and msg_lrpid members are of type pid_t, which is a 32-bit
>> integer.
>>
>> Signed-off-by: Andreas Schwab <schwab@suse.de>
>> ---
>>   linux-user/syscall.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index 0956a7b310..3dcdb3ef42 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -4185,8 +4185,8 @@ struct target_msqid_ds
>>       abi_ulong __msg_cbytes;
>>       abi_ulong msg_qnum;
>>       abi_ulong msg_qbytes;
>> -    abi_ulong msg_lspid;
>> -    abi_ulong msg_lrpid;
>> +    unsigned int msg_lspid;
>> +    unsigned int msg_lrpid;
> 
> This should be target_pid_t.

Ho hum, target_pid_t is private to elfload.c.

Since this is

include/uapi/asm-generic/posix_types.h:typedef int              __kernel_ipc_pid_t;
include/uapi/linux/msg.h:       __kernel_ipc_pid_t msg_lspid;   /* pid of last msgsnd */
include/uapi/linux/msg.h:       __kernel_ipc_pid_t msg_lrpid;   /* last receive pid */

I.e. not really just pid_t, then let's go ahead and use abi_int and have a comment.


r~