From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E712FC433EF for ; Mon, 28 Feb 2022 14:29:21 +0000 (UTC) Received: from localhost ([::1]:40428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOh1c-0005Gr-J2 for qemu-devel@archiver.kernel.org; Mon, 28 Feb 2022 09:29:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOgiL-0003ba-PH for qemu-devel@nongnu.org; Mon, 28 Feb 2022 09:09:26 -0500 Received: from smtpout3.mo529.mail-out.ovh.net ([46.105.54.81]:60375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOgiK-0007oR-3C for qemu-devel@nongnu.org; Mon, 28 Feb 2022 09:09:25 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.109.143.118]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id 3A4C6E454B31; Mon, 28 Feb 2022 15:09:19 +0100 (CET) Received: from kaod.org (37.59.142.95) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Mon, 28 Feb 2022 15:09:19 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-95G00160def291-c4e7-478e-a797-39b1c7d63c3b, 252894939833E8233A028C6995915A29C4CB1534) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: Date: Mon, 28 Feb 2022 15:09:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 2/3] spapr: Add SPAPR_CAP_AIL_MODE_3 for AIL mode 3 support for H_SET_MODE hcall Content-Language: en-US To: David Gibson , Nicholas Piggin References: <20220216063903.1782281-1-npiggin@gmail.com> <20220216063903.1782281-2-npiggin@gmail.com> <1645601745.av9rgobn2v.astroid@bobo.none> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.95] X-ClientProxiedBy: DAG6EX1.mxp5.local (172.16.2.51) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: d308a60b-e0e2-4a9a-a39b-33db687ff7b5 X-Ovh-Tracer-Id: 15532633640614726563 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvvddruddttddgheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhjggtgfhisehtjeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhephffhleegueektdetffdvffeuieeugfekkeelheelteeftdfgtefffeehueegleehnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrdelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdpnhgspghrtghpthhtohepuddprhgtphhtthhopehqvghmuhdqphhptgesnhhonhhgnhhurdhorhhg Received-SPF: pass client-ip=46.105.54.81; envelope-from=clg@kaod.org; helo=smtpout3.mo529.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Fabiano Rosas Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" >>>> + /* These tests match the CPU_FTR_P9_RADIX_PREFETCH_BUG flag in Linux */ >>>> + if (((pcc->pvr & 0xffffff00) == CPU_POWERPC_POWER9_DD1) || >>>> + ((pcc->pvr & 0xffffff00) == CPU_POWERPC_POWER9_DD20) || >>>> + ((pcc->pvr & 0xffffff00) == CPU_POWERPC_POWER9_DD21)) { >>>> + return 0; >>>> + } >>> >>> Deducing what KVM supports rather than getting it to tell us >>> explicitly with a cap is usually frowned upon. However, given the >>> earlier discussion, I'm satisfied that this is the least bad available >>> option, at least for now. >> >> BTW this particular test doesn't work as I hoped because we only have >> a power9 dd2.0 model. > > Oh.. yes... IIRC dd2.0 is barely present in the wild, since it doesn't > have vital Spectre mitigations.... > >> Adding a 2.2 or 2.3 would be possible. Maybe overkill. I'll change >> the test just to catch all POWER9 for now. > > ... no, given the above, I think we should definitely add the newer > models. Maybe even remove dd2.0 and replace it with the newer ones. yes. It's really not a big effort. Thanks, C.