From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D52E7C433DB for ; Wed, 20 Jan 2021 15:41:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79E0A233EB for ; Wed, 20 Jan 2021 15:41:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79E0A233EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47580 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Fbx-0002Fq-H7 for qemu-devel@archiver.kernel.org; Wed, 20 Jan 2021 10:41:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2FSg-00011a-W9 for qemu-devel@nongnu.org; Wed, 20 Jan 2021 10:31:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l2FSa-0003ir-Hr for qemu-devel@nongnu.org; Wed, 20 Jan 2021 10:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611156708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xat5P+s9V14fTaLNV/hUrsmsnbnWz3bbP2Kd92nPp8w=; b=TwgOxDPUaCXqLCdogmko8MGFLV1UACemk96etNi2Nr4zGCogTwjVX1/t1A3IzunVvE0RUi zV5sOeN1G9XetvNq59RVb1blPvnU3EWZIMFgLRb0/CJBHqsvzikM40Nwxjemauuy5lXtFD xaVh/IOfAh/uCsd5ki5IR6hkYkoc0CA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-ri9FZNKYOy2O-nGcqqGC_w-1; Wed, 20 Jan 2021 10:31:46 -0500 X-MC-Unique: ri9FZNKYOy2O-nGcqqGC_w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D7013806662 for ; Wed, 20 Jan 2021 15:31:44 +0000 (UTC) Received: from [10.3.113.116] (ovpn-113-116.phx2.redhat.com [10.3.113.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78AD01002C10; Wed, 20 Jan 2021 15:31:40 +0000 (UTC) To: Paolo Bonzini , qemu-devel@nongnu.org References: <20210120144235.345983-1-pbonzini@redhat.com> <20210120144235.345983-3-pbonzini@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Subject: Re: [PATCH 2/3] qmp: remove deprecated "change" command Message-ID: Date: Wed, 20 Jan 2021 09:31:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210120144235.345983-3-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, kraxel@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/20/21 8:42 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/system/deprecated.rst | 5 ---- > docs/system/removed-features.rst | 5 ++++ > monitor/qmp-cmds.c | 51 -------------------------------- > qapi/misc.json | 49 ------------------------------ > 4 files changed, 5 insertions(+), 105 deletions(-) > > -``change`` (since 2.5.0) > -'''''''''''''''''''''''' > - > -Use ``blockdev-change-medium`` or ``change-vnc-password`` instead. We didn't document a fallback for changing the vnc listener... > +++ b/docs/system/removed-features.rst > @@ -53,6 +53,11 @@ are automatically loaded from qcow2 images. > Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See > documentation of ``query-hotpluggable-cpus`` for additional details. > > +``change`` (removed in 6.0) > +''''''''''''''''''''''''''' > + > +Use ``blockdev-change-medium`` or ``change-vnc-password`` instead. ...and still don't,... > -static void qmp_change_vnc(const char *target, bool has_arg, const char *arg, > - Error **errp) > -{ > - if (strcmp(target, "passwd") == 0 || strcmp(target, "password") == 0) { > - if (!has_arg) { > - error_setg(errp, QERR_MISSING_PARAMETER, "password"); > - } else { > - qmp_change_vnc_password(arg, errp); > - } > - } else { > - qmp_change_vnc_listen(target, errp); ...and now we're entirely removing that QMP ability, without deprecation. Is that intended? > +++ b/qapi/misc.json > @@ -238,55 +238,6 @@ > 'returns': 'str', > 'features': [ 'savevm-monitor-nodes' ] } > > -## > -# @change: > -# > -# This command is multiple commands multiplexed together. > -# > -# @device: This is normally the name of a block device but it may also be 'vnc'. > -# when it's 'vnc', then sub command depends on @target > -# > -# @target: If @device is a block device, then this is the new filename. > -# If @device is 'vnc', then if the value 'password' selects the vnc > -# change password command. Otherwise, this specifies a new server URI > -# address to listen to for VNC connections. That is, I'm wondering if we should be adding a change-vnc-listener QMP command, and extending the deprecation for 2 more releases to allow this final use of 'change vnc' to still work. Or are we really at the point where we have no known users? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org