From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EBCDC433F5 for ; Tue, 16 Nov 2021 12:10:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5AF3615E2 for ; Tue, 16 Nov 2021 12:10:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E5AF3615E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mmxHm-0001w9-PN for qemu-devel@archiver.kernel.org; Tue, 16 Nov 2021 07:10:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mmxGj-0008Md-M9 for qemu-devel@nongnu.org; Tue, 16 Nov 2021 07:08:57 -0500 Received: from [2a00:1450:4864:20::332] (port=53895 helo=mail-wm1-x332.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mmxGh-00065E-UE for qemu-devel@nongnu.org; Tue, 16 Nov 2021 07:08:57 -0500 Received: by mail-wm1-x332.google.com with SMTP id y196so16682179wmc.3 for ; Tue, 16 Nov 2021 04:08:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IgKg0Ai0yjKlbpvtP8SqPraRkPfaxY7/PrE17+6WNkQ=; b=x6ovScYSnu9bcvUOLuyFrBk4s1aAlmR4SSERQF3wE0shnJ3C4nv9ggWSuN3/7Ds6u+ mt+xnSEjbcoDg9UDJF3G8Mfwwk03Ztx3N9IFsYadl9PQYnEdzeWvgotwVeYjheBoX97s fceFmomv2+4khFAKoixqM2+CedwmIpb7RhcZOfOS0t1f52Wz+At2n2BCDWjra1OVAmYC P34rS0sxHYd3JwwR3QSNN2VBw71k/QRaQ7EWChVypiGvanHLDrX7ZFgi9GnBOhlStqck zHNO4Tz7UlaXJzz40i6FCUYp4ZGlbA58nVpAO51Ra11BdlaDboavx3B+2JyPE4EphQji EXyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IgKg0Ai0yjKlbpvtP8SqPraRkPfaxY7/PrE17+6WNkQ=; b=4V4n40+h/Ox+hwI1vF52aUQBnOv8aKnvS77NYpVD/UExohTSKdKXcPNQPwIBOez1RG V/D+EYckTkN71+8jYXC4un3+2bZPVWkmSqf5Y9ztzucCVkp28tJeyGBKXKoCI07pmcxG xrBKbIYVk+A0cX5XhpF6XbNtxxdT09gzrjQcfr9+pL9Nqgg2fMgQENCvmUpOIgDE6aRO ssCzD6YRD1nMS4HPhCZiAHEX9m3MuZXYzHIMrUok/iirt0/8jxplS23Psyg7/W7oIpWP vWqE/9xsKkj6ie98S6oAEN6LTvV8mF5pdfEUzts0qDM/lPJo0d1c3xxnKyEzGwXpqQHC XGYw== X-Gm-Message-State: AOAM532L8yJZOAncPRqTNbFgfzNeqVC/PX4Mgdeo29oeItkjGcBxZjP5 IIYwiL9VqGBktMaq7/bgRhm++g== X-Google-Smtp-Source: ABdhPJww7p3oGQ7pdDmWZW9mSKq6IhCbpqmvuItNNo6dJadfcKMpDbY+wX5UfqK8d0R33f2V4tG2mw== X-Received: by 2002:a7b:c2a1:: with SMTP id c1mr19647679wmk.112.1637064534547; Tue, 16 Nov 2021 04:08:54 -0800 (PST) Received: from [192.168.8.105] (145.red-37-158-173.dynamicip.rima-tde.net. [37.158.173.145]) by smtp.gmail.com with ESMTPSA id c5sm18329676wrd.13.2021.11.16.04.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 04:08:54 -0800 (PST) Subject: Re: [PATCH-for-7.0 v4 08/11] tests/unit/test-smp-parse: Add 'smp-without-dies-valid' machine type To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20211115145900.2531865-1-philmd@redhat.com> <20211115145900.2531865-9-philmd@redhat.com> From: Richard Henderson Message-ID: Date: Tue, 16 Nov 2021 13:08:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211115145900.2531865-9-philmd@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::332 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.446, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yanan Wang , Andrew Jones , Eduardo Habkost , Thomas Huth , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/15/21 3:58 PM, Philippe Mathieu-Daudé wrote: > Keep the common TYPE_MACHINE class initialization in > machine_base_class_init(), make it abstract, and move > the non-common code to a new class: "smp-without-dies-valid". > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/unit/test-smp-parse.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~