Re: [Qemu-devel] [PATCH] cryptodev: remove dead code

[Paolo Bonzini <pbonzini@redhat.com>]

On 30/07/2018 13:50, Zhoujian (jay) wrote:
> Hi Paolo,
> 
> I've posted a patch before, pls see
> https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05215.html
> 
> which reviewed by Stefan
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg01549.html
> 
> It seems that it hasn't been merged. Could you pick it up pls?

Yes, I will.

Paolo

> Regards,
> Jay
> 
>> -----Original Message-----
>> From: Qemu-devel [mailto:qemu-devel-
>> bounces+jianjay.zhou=huawei.com@nongnu.org] On Behalf Of Paolo Bonzini
>> Sent: Monday, July 30, 2018 4:51 PM
>> To: qemu-devel@nongnu.org
>> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
>>
>> Reported by Coverity as CID 1390600.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  backends/cryptodev-vhost-user.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-
>> user.c index d52daccfcd..d539f14d59 100644
>> --- a/backends/cryptodev-vhost-user.c
>> +++ b/backends/cryptodev-vhost-user.c
>> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int
>> event)  {
>>      CryptoDevBackendVhostUser *s = opaque;
>>      CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
>> -    Error *err = NULL;
>>      int queues = b->conf.peers.queues;
>>
>>      assert(queues < MAX_CRYPTO_QUEUE_NUM); @@ -174,10 +173,6 @@ static void
>> cryptodev_vhost_user_event(void *opaque, int event)
>>          cryptodev_vhost_user_stop(queues, s);
>>          break;
>>      }
>> -
>> -    if (err) {
>> -        error_report_err(err);
>> -    }
>>  }
>>
>>  static void cryptodev_vhost_user_init(
>> --
>> 2.17.1
>>
>