From: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Nico Boehr" <nrb@linux.ibm.com>
Subject: Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup
Date: Mon, 09 Sep 2024 15:47:01 +0200 [thread overview]
Message-ID: <a5f652ee4c6563cc10daf650fdaff34d738f2da1.camel@linux.ibm.com> (raw)
In-Reply-To: <CAFEAcA_pHTRTDwH0dG3QAKx3x9xdJgG5xtrwo5diV6QgBqf+8Q@mail.gmail.com>
On Fri, 2024-09-06 at 15:38 +0100, Peter Maydell wrote:
> On Fri, 30 Aug 2024 at 15:58, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > The main aim of this patchseries is to remove the two remaining uses
> > of device_class_set_parent_reset() in the tree, which are virtio-ccw
> > and the s390 CPU class. Doing that lets us do some followup cleanup.
> > (The diffstat looks alarming but is almost all coccinelle automated
> > changes.)
> >
> > Changes v1->v2:
> > * new patch 1 to convert hw/s390/ccw-device
> > (fixes bug discovered via s390 CI testing in v1)
> > * a couple of patches are already upstream
> > * in the target/s390 cpu patch, fix sigp_cpu_reset() to use
> > RESET_TYPE_S390_CPU_NORMAL
> > * new patches 10, 11 which take advantage of the new function
> > device_class_set_legacy_reset() to allow us to replace the
> > generic Resettable transitional_function machinery with a
> > simple wrapper that adapts from the API of the hold method
> > to the one used by the legacy reset method
> >
> > Patches 1, 10, 11 need review. I believe that patch 1 should have
> > fixed the intermittent s390 issue we found with v1 of the patchset,
> > but if you could run these through the s390 CI again I'd
> > appreciate it.
>
> I'm going to apply this series to my target-arm.next queue.
>
> Let me know if you need more time to CI/test/whatever it on
> the s390 side before it goes upstream.
CI looks good.
>
> thanks
> -- PMM
prev parent reply other threads:[~2024-09-09 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 14:58 [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup Peter Maydell
2024-08-30 14:58 ` [PATCH v2 01/11] hw/s390/ccw-device: Convert to three-phase reset Peter Maydell
2024-09-03 12:33 ` Nina Schoetterl-Glausch
2024-09-03 14:53 ` Philippe Mathieu-Daudé
2024-09-04 6:21 ` Thomas Huth
2024-08-30 14:58 ` [PATCH v2 02/11] hw/s390/virtio-ccw: " Peter Maydell
2024-08-30 14:58 ` [PATCH v2 03/11] target/s390: Convert CPU to Resettable interface Peter Maydell
2024-08-30 14:58 ` [PATCH v2 04/11] hw: Remove device_class_set_parent_reset() Peter Maydell
2024-08-30 14:58 ` [PATCH v2 05/11] target/alpha, hppa: Remove unused parent_reset fields Peter Maydell
2024-09-03 14:42 ` Philippe Mathieu-Daudé
2024-08-30 14:58 ` [PATCH v2 06/11] hw: Define new device_class_set_legacy_reset() Peter Maydell
2024-08-30 14:58 ` [PATCH v2 07/11] hw: Use device_class_set_legacy_reset() instead of opencoding Peter Maydell
2024-08-30 14:58 ` [PATCH v2 08/11] hw: Rename DeviceClass::reset field to legacy_reset Peter Maydell
2024-08-30 14:58 ` [PATCH v2 09/11] hw: Remove device_phases_reset() Peter Maydell
2024-08-30 14:58 ` [PATCH v2 10/11] hw/core/qdev: Simplify legacy_reset handling Peter Maydell
2024-09-03 14:52 ` Philippe Mathieu-Daudé
2024-08-30 14:58 ` [PATCH v2 11/11] hw/core/resettable: Remove transitional_function machinery Peter Maydell
2024-09-03 14:52 ` Philippe Mathieu-Daudé
2024-09-06 14:38 ` [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup Peter Maydell
2024-09-09 13:47 ` Nina Schoetterl-Glausch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f652ee4c6563cc10daf650fdaff34d738f2da1.camel@linux.ibm.com \
--to=nsg@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=nrb@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).